Chris feedback

multiprocessing_talk/__main__.py

@@ -1,16 +1,16 @@
-from ismain import is_main
-from multiprocessing_talk import main_process, main_pool
+from pathlib import Path
 
 from balsa import Balsa
+from ismain import is_main
 
-from multiprocessing_talk import application_name, author
+from multiprocessing_talk import application_name, author, main_process, main_pool
 
 
 def main():
     balsa = Balsa(
         application_name,
         author,
-        log_directory="log",
+        log_directory=Path("multiprocessing_talk", "log"),
         delete_existing_log_files=True,
         verbose=False,  # turn verbose on/off to show logging into stdout
     )

multiprocessing_talk/pool.py

@@ -30,7 +30,9 @@ def main_pool(balsa: Balsa):
 
         # run the workers using .apply_async()
         e_process = pool.apply_async(calculate_e, args=(e_exit_event, balsa_config))
-        dir_path = Path(Path(".").absolute().anchor, "Program Files", "Python310")
+        # replace hardcoded path so code works when people clone repo
+        # dir_path = Path(Path(".").absolute().anchor, "Program Files", "Python310")
+        dir_path = Path.cwd() / "venv"
         dir_info_result = pool.apply_async(
             get_dir_info,
             args=(dir_path, balsa_config),

multiprocessing_talk/process.py

@@ -80,7 +80,10 @@ def main_process(balsa: Balsa):
     log.info(f"starting {application_name}")
     e_process = CalculateE(balsa_config)  # pass in log config
     e_process.start()  # calculates e
-    dir_info_process = GetDirInfo(Path(Path(".").absolute().anchor, "Program Files", "Python310"), balsa_config)
+    # replace hardcoded path so code works when people clone repo
+    # dir_info_process = GetDirInfo(Path(Path(".").absolute().anchor, "Program Files", "Python310"), balsa_config)
+    dir_info_process = GetDirInfo(
+        Path.cwd(), balsa_config)
     dir_info_process.start()
 
     # request exit from "e" process and wait for dir info
@@ -92,7 +95,8 @@ def main_process(balsa: Balsa):
     print(dir_info_process.get())
     e_process.exit_event.set()
     e_value, e_iterations, e_duration = e_process.get()
-    print(f"calculated {e_value=} for {e_iterations:,} iterations in {e_duration} seconds")
+    print(f"\n"
+          f"calculated {e_value=} for {e_iterations:,} iterations in {e_duration} seconds")
 
     print(f"total time: {time.time() - start} seconds")
     print()