Checking all children of a node should only check the root node

[williamboman]

Say you have made a selection like so;

Shouldn't All be the only item in the checked array in this scenario? Cause right now, every children will populate the checked array, and the root node will not be included. Or am I wrong here?

[jakezatecky]

There are a few ways to go about here:

1. Record leaf nodes in checked. Here, we only care about the leaf nodes. This is the current model.
2. Record upper-most nodes in checked. Here, we care about top-most checked nodes; the component needs to be intelligent enough to only record nodes that do not have a parent node checked. This is the model you are suggesting.
3. Record every checked node in checked. Here, we care about EVERY node selected, whether it is a parent, child, or leaf.

While the react-checkbox-tree component currently uses the first model, I do not see why we could not also support the other two models. Could be a component parameter.

[qodesmith]

Any progress on these models? I could use the 3rd one - "Record every checked node in checked".

[jakezatecky]

@qodesmith No progress has been made. Much of the component makes assumptions about check state based on child nodes. Nevertheless, of the additional models, the third one you are wanting is the easier one to implement.

A PR is welcome. Otherwise, I'll get to this when I can. I certainly agree that it would be useful to have implemented.

[VikramMaiya]

Hi, The component designed by you is very useful but
Even I Wanted 3d functionality:
checked array must contain all the checked nodes including parents.
Awaiting your response.

[VikramMaiya]

Hi,
Currently I am using "react-checkbox-tree": "^1.0.1"

I tried updating to your V1.1.0:
npm install react-checkbox-tree@1.1.0 --save

I got the following error:
No matching version found for react-checkbox-tree@1.1.0

[williamboman]

@VikramMaiya There are no 1.1.0 release yet.

[VikramMaiya]

Hi William,
checked array must contain all the checked nodes including parents.
Could you help me ?

[jakezatecky]

@VikramMaiya None of that is implemented yet. I only marked it for next release.

[VikramMaiya]

Hi jakezatecky,
Thanks for your quick response. How long will it take for the next release ?

[karan-chauhan]

Hi jakezatecky,
I also want all the checked nodes including parent, child. Can you please help me? And how long will it take for the next release..?

[karan-chauhan]

I solved some of my issue, but its not fully done. With this code, i can get the id of my parent, when i select all the values using parent. But if i deselect one of my child then it doesn't exclude the parent value from checked array. Here is the code that i changed:

key: 'toggleChecked',
        value: function toggleChecked(node, isChecked, noCascade) {
            var _this3 = this;

            if (node.children === null || noCascade) {
                // Set the check status of a leaf node or an uncoupled parent
                this.toggleNode('checked', node, isChecked);
            } else {
                //Change by karan
                this.toggleNode('checked', node, isChecked);

                // Percolate check status down to all children
                node.children.forEach(function (child) {
                    _this3.toggleChecked(child, isChecked);
                });
            }
        }