slightly speed up param parsing

Author: jakebailey

helpers.go

@@ -18,6 +18,13 @@ func stringFields(s string, sep byte) []string {
 		return []string{s}
 	}
 
+	s = fastTrim(s, sep)
+
+	count = strings.Count(s, string(sep))
+	if count == 0 {
+		return []string{s}
+	}
+
 	out := make([]string, 0, count+1)
 
 	for {
@@ -45,6 +52,37 @@ func stringFields(s string, sep byte) []string {
 	return out
 }
 
+// fastTrim is a faster implementation of trimming a string against a single
+// byte.
+func fastTrim(s string, b byte) string {
+	br := rune(b)
+
+	findLeft := true
+	left := 0
+
+	prevB := false
+	right := 0
+
+	for i, r := range s {
+		if findLeft {
+			if r != br {
+				left = i
+				findLeft = false
+			}
+			continue
+		}
+
+		if r != br && prevB {
+			prevB = false
+			right = i
+		} else {
+			prevB = true
+		}
+	}
+
+	return s[left : right+1]
+}
+
 var (
 	tagEscapeReplacer   = strings.NewReplacer(";", `\:`, " ", `\s`, "\r", `\r`, "\n", `\n`, "\\", `\\`)
 	tagUnescapeReplacer = strings.NewReplacer(`\:`, ";", `\s`, " ", `\r`, "\r", `\n`, "\n", `\\`, "\\")