Relax the scope requirement for public fields #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
force-pushed
the
public-fields-scope-requirement
branch
from
61bdd60 to
71942ea
Compare
Ladicek
changed the title
|
@Ladicek shouldn't we add a test that verifies this for |
|
We could, but it's not like we can ever be exhaustive. For normal scopes, we only test |
True, I only mentioned this as it is a notable difference from previous version of specification. |
manovotn
approved these changes
Nov 8, 2023
|
I could add a test for OK, I will do it :-) |
This is a TCK counterpart to the specification change that allows all pseudo-scoped beans to have public fields. It updates the text in `tck-audit-cdi.xml` files, fixes naming in the relevant tests and adds a test that a `@Singleton` bean can have a public field.
Ladicek
force-pushed
the
public-fields-scope-requirement
branch
from
71942ea to
b52a23d
Compare
|
Done. |
manovotn
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a TCK counterpart to the specification change that allows all pseudo-scoped beans to have public fields. It updates the text in
tck-audit-cdi.xmlfiles, fixes naming in the relevant tests and adds a test that a@Singletonbean can have a public field.