Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some comments #4410

Merged
merged 2 commits into from
May 27, 2023
Merged

fix some comments #4410

merged 2 commits into from
May 27, 2023

Conversation

cuishuang
Copy link
Contributor

No description provided.

Signed-off-by: cui fliter <imcusg@gmail.com>
@cuishuang cuishuang requested a review from a team as a code owner April 25, 2023 05:54
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (015020d) 97.05% compared to head (4a22cf6) 97.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4410   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files         300      300           
  Lines       17740    17740           
=======================================
  Hits        17217    17217           
  Misses        419      419           
  Partials      104      104           
Flag Coverage Δ
unittests 97.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/agent/app/reporter/grpc/reporter.go 100.00% <ø> (ø)
cmd/query/app/query_parser.go 100.00% <ø> (ø)
...in/sampling/strategystore/static/strategy_store.go 97.26% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 9c2d96a into jaegertracing:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants