Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove pkg/multicloser #4291

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

yurishkuro
Copy link
Member

Can achieve the same result with errors.Join

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner March 11, 2023 04:49
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (607b5a8) 97.10% compared to head (3867084) 97.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4291      +/-   ##
==========================================
- Coverage   97.10%   97.09%   -0.01%     
==========================================
  Files         302      301       -1     
  Lines       17685    17675      -10     
==========================================
- Hits        17173    17162      -11     
- Misses        412      413       +1     
  Partials      100      100              
Flag Coverage Δ
unittests 97.09% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/agent/app/reporter/grpc/collector_proxy.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit a172bcc into jaegertracing:main Mar 11, 2023
mx-psi added a commit to mx-psi/jaeger that referenced this pull request Mar 22, 2023
This reverts commit a172bcc.

Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant