Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WithTenant() lost orig context #3685

Merged
merged 1 commit into from
May 16, 2022

Conversation

esnible
Copy link
Contributor

@esnible esnible commented May 16, 2022

Signed-off-by: Ed Snible snible@us.ibm.com

We missed a cut-and-paste error on the review of the previous PR #3661

Fixed the bug and added a test for it.

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible requested a review from a team as a code owner May 16, 2022 20:01
@esnible esnible requested a review from yurishkuro May 16, 2022 20:01
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #3685 (c076573) into main (2fd214e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3685      +/-   ##
==========================================
- Coverage   96.59%   96.58%   -0.02%     
==========================================
  Files         268      268              
  Lines       15717    15717              
==========================================
- Hits        15182    15180       -2     
- Misses        446      447       +1     
- Partials       89       90       +1     
Impacted Files Coverage Δ
storage/tenant.go 100.00% <100.00%> (ø)
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd214e...c076573. Read the comment docs.

@yurishkuro yurishkuro enabled auto-merge (squash) May 16, 2022 20:20
@yurishkuro yurishkuro merged commit 84db6f4 into jaegertracing:main May 16, 2022
@esnible esnible deleted the withtenant-bug branch May 17, 2022 13:15
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants