Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.18 #3624

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

yurishkuro
Copy link
Member

Resolves #3622

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner April 12, 2022 14:04
@yurishkuro yurishkuro mentioned this pull request Apr 12, 2022
4 tasks
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #3624 (27d5735) into main (4509ef1) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3624      +/-   ##
==========================================
- Coverage   96.56%   96.51%   -0.06%     
==========================================
  Files         264      264              
  Lines       15449    15449              
==========================================
- Hits        14919    14911       -8     
- Misses        447      453       +6     
- Partials       83       85       +2     
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️
plugin/storage/badger/spanstore/reader.go 95.50% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4509ef1...27d5735. Read the comment docs.

@yurishkuro yurishkuro merged commit 4beb037 into jaegertracing:main Apr 12, 2022
@yurishkuro yurishkuro deleted the upgrade-golintci branch April 12, 2022 14:55
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.18
1 participant