fix(integration): no spans in the future #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
force-pushed
the
no-future
branch
from
c31fe3b
to
c9a48d3
Compare
Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>
johanneswuerbach
force-pushed
the
no-future
branch
from
c9a48d3
to
b4bc17f
Compare
Codecov Report
@@ Coverage Diff @@
## main #3538 +/- ##
==========================================
- Coverage 96.50% 96.48% -0.02%
==========================================
Files 263 263
Lines 15376 15376
==========================================
- Hits 14839 14836 -3
- Misses 454 456 +2
- Partials 83 84 +1
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Feb 19, 2022
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com> Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I'm using the integration test framework to test my custom grpc plugin, which is working great, except that it can't really deal with traces hours in the future.
Traces in the future are happening if you run the tests before 16:00 UTC as on fixture loading only the date is replaced with the current day, but not the time.
If I run my tests after 17:00 UTC all tests pass as all spans are now in the past.
Short description of the changes