Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid --agent.tags #3246

Merged

Conversation

esnible
Copy link
Contributor

@esnible esnible commented Sep 3, 2021

If --agent.tags (or other tags) are malformed, display the invalid value as part of the panic.

No related Github issue. Found this while testing the operator. Improves an error message that will appear in the pod log if a misconfiguration keeps the Jaeger Query deployment from starting.

Old message:

panic: runtime error: index out of range [1] with length 1

New Message

panic: invalid Jaeger tag pair "dummy", expected key=value

Reproduce by building locally and running ~/go/src/github.com/jaegertracing/jaeger/cmd/query/query-darwin-amd64 --agent.tags=dummy

…ue as part of the panic

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible requested a review from a team as a code owner September 3, 2021 17:07
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #3246 (e4eb68b) into master (27fe841) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3246      +/-   ##
==========================================
+ Coverage   95.98%   96.00%   +0.02%     
==========================================
  Files         242      242              
  Lines       14813    14815       +2     
==========================================
+ Hits        14218    14223       +5     
+ Misses        515      513       -2     
+ Partials       80       79       -1     
Impacted Files Coverage Δ
cmd/flags/flags.go 48.21% <100.00%> (+1.91%) ⬆️
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
plugin/storage/integration/integration.go 79.28% <0.00%> (+0.39%) ⬆️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️
cmd/collector/app/server/zipkin.go 70.73% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27fe841...e4eb68b. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro enabled auto-merge (squash) September 3, 2021 17:56
@yurishkuro yurishkuro merged commit 93adddd into jaegertracing:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants