Add SendGetBodyAs flag on elasticsearch storage #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Aug 6, 2021
NatMarchand
force-pushed
the
feature/es-sendgetbodyas
branch
2 times, most recently
from
a3d81d7
to
9fcc0fd
Compare
|
I've formatted code, improved the description such as suggested. I'm not sure if I have to add tests before removing Draft ? |
yurishkuro
reviewed
Aug 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #3193 +/- ##
==========================================
- Coverage 95.94% 95.92% -0.02%
==========================================
Files 239 239
Lines 14655 14661 +6
==========================================
+ Hits 14061 14064 +3
- Misses 518 520 +2
- Partials 76 77 +1
Continue to review full report at Codecov.
|
NatMarchand
force-pushed
the
feature/es-sendgetbodyas
branch
from
9fcc0fd
to
78cf434
Compare
Signed-off-by: Nathanael Marchand <nathanael.marchand@outlook.com>
NatMarchand
force-pushed
the
feature/es-sendgetbodyas
branch
from
3252ce0
to
3ec791b
Compare
yurishkuro
approved these changes
Aug 8, 2021
yurishkuro
changed the title
yurishkuro
changed the title
|
Thanks! |
|
Thank you for your quick feedback and approval ! Glad to have contributed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathanael Marchand nathanael.marchand@outlook.com
Which problem is this PR solving?
Resolves #3191
Short description of the changes
This PR configures the property SendGetBodyAs on the elastic search client to allow sending HTTP requests with a body with another verb than GET (which might cause networking issue on some WAF or load balancers).
In order to do that, I've created an option -es.send-get-body-as to specify the verb to use.
I open this PR early to gather feedback as Go is not my native development language ;)