Skip to content

Add context to spanstore.Writer interface #2006

Closed

Description

Problem - what in Jaeger blocks you from solving the requirement?

type Writer interface {
WriteSpan(span *model.Span) error
}

The spanstore.Writer interface does not propagate context.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add a new WriteSpanWithContext(ctx context.Context, span *model.Span) error to propagate context.

Alternatively, we may update to WriteSpan(ctx context.Context, *model.Span) error.

Unfortunately, both of these are breaking changes. Alternatively, we may create a WriterV2 interface, and supply a converter from Writer to WriterV2. Such a converter would simply use ctx.Background() for the context parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions