From ad4419e493b28f494b978727114dfd000291363a Mon Sep 17 00:00:00 2001 From: Yuri Shkuro Date: Tue, 1 Sep 2020 15:45:19 -0400 Subject: [PATCH] add TODOs Signed-off-by: Yuri Shkuro --- cmd/collector/app/span_processor.go | 1 + cmd/ingester/app/processor/span_processor.go | 1 + 2 files changed, 2 insertions(+) diff --git a/cmd/collector/app/span_processor.go b/cmd/collector/app/span_processor.go index cfc853549d1..3a568a5d0b7 100644 --- a/cmd/collector/app/span_processor.go +++ b/cmd/collector/app/span_processor.go @@ -141,6 +141,7 @@ func (sp *spanProcessor) saveSpan(span *model.Span) { } startTime := time.Now() + // TODO context should be propagated from upstream components if err := sp.spanWriter.WriteSpan(context.TODO(), span); err != nil { sp.logger.Error("Failed to save span", zap.Error(err)) sp.metrics.SavedErrBySvc.ReportServiceNameForSpan(span) diff --git a/cmd/ingester/app/processor/span_processor.go b/cmd/ingester/app/processor/span_processor.go index db0587206ab..ad1c8aa7479 100644 --- a/cmd/ingester/app/processor/span_processor.go +++ b/cmd/ingester/app/processor/span_processor.go @@ -63,5 +63,6 @@ func (s KafkaSpanProcessor) Process(message Message) error { if err != nil { return fmt.Errorf("cannot unmarshall byte array into span: %w", err) } + // TODO context should be propagated from upstream components return s.writer.WriteSpan(context.TODO(), span) }