Skip to content

Commit 82f14b7

Browse files
author
Louis-Etienne Dorval
committed
fmt the new Kafka consumer/producer code
1 parent cbbd319 commit 82f14b7

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

cmd/ingester/app/flags.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ func (o *Options) InitFromViper(v *viper.Viper) {
134134
o.GroupID = v.GetString(KafkaConsumerConfigPrefix + SuffixGroupID)
135135
o.Encoding = v.GetString(KafkaConsumerConfigPrefix + SuffixEncoding)
136136

137-
if brokers := v.GetString(DeprecatedKafkaConfigPrefix+SuffixBrokers); brokers != "" {
137+
if brokers := v.GetString(DeprecatedKafkaConfigPrefix + SuffixBrokers); brokers != "" {
138138
fmt.Printf("WARNING: found deprecated option %s, please use %s instead\n",
139139
DeprecatedKafkaConfigPrefix+SuffixBrokers,
140140
KafkaConsumerConfigPrefix+SuffixBrokers,

cmd/ingester/app/flags_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,4 @@ func TestOptionsWithAllFlags(t *testing.T) {
9494
assert.Equal(t, []string{"127.0.0.1:9092", "0.0.0:1234"}, o.Brokers)
9595
assert.Equal(t, "group1", o.GroupID)
9696
assert.Equal(t, kafka.EncodingProto, o.Encoding)
97-
}
97+
}

plugin/storage/kafka/options.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ const (
3232
// EncodingZipkinThrift is used for spans encoded as Zipkin Thrift.
3333
EncodingZipkinThrift = "zipkin-thrift"
3434

35-
configPrefix = "kafka.producer"
36-
deprecatedPrefix = "kafka"
37-
suffixBrokers = ".brokers"
38-
suffixTopic = ".topic"
39-
suffixEncoding = ".encoding"
35+
configPrefix = "kafka.producer"
36+
deprecatedPrefix = "kafka"
37+
suffixBrokers = ".brokers"
38+
suffixTopic = ".topic"
39+
suffixEncoding = ".encoding"
4040

4141
defaultBroker = "127.0.0.1:9092"
4242
defaultTopic = "jaeger-spans"
@@ -94,7 +94,7 @@ func (opt *Options) InitFromViper(v *viper.Viper) {
9494
opt.topic = v.GetString(configPrefix + suffixTopic)
9595
opt.encoding = v.GetString(configPrefix + suffixEncoding)
9696

97-
if brokers := v.GetString(deprecatedPrefix+suffixBrokers); brokers != "" {
97+
if brokers := v.GetString(deprecatedPrefix + suffixBrokers); brokers != "" {
9898
fmt.Printf("WARNING: found deprecated option %s, please use %s instead\n",
9999
deprecatedPrefix+suffixBrokers,
100100
configPrefix+suffixBrokers,

plugin/storage/kafka/options_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,4 @@ func TestOptionsWithAllFlags(t *testing.T) {
7676
assert.Equal(t, "topic1", opts.topic)
7777
assert.Equal(t, []string{"127.0.0.1:9092", "0.0.0:1234"}, opts.config.Brokers)
7878
assert.Equal(t, "protobuf", opts.encoding)
79-
}
79+
}

0 commit comments

Comments
 (0)