From 286997c398b3489701f55ac054edfdd790ab7a3b Mon Sep 17 00:00:00 2001 From: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com> Date: Sun, 24 Dec 2023 23:09:30 +0530 Subject: [PATCH] ci: Simplify check-label workflow (#5033) ## Which problem is this PR solving? Fixes a deprecation in the workflow as [outlined here](https://github.com/jaegertracing/jaeger-ui/issues/2067) ## Description of the changes Removed the `set-output` command in favor of the new environment variable by GitHub. ## How was this change tested? NA ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com> --- .github/workflows/ci-label-check.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/ci-label-check.yml b/.github/workflows/ci-label-check.yml index 8b4413a1459..55c9f2d9dfc 100644 --- a/.github/workflows/ci-label-check.yml +++ b/.github/workflows/ci-label-check.yml @@ -19,12 +19,8 @@ jobs: with: egress-policy: audit - - name: Check PR author - id: check_author - run: echo "::set-output name=is_dependabot::$(echo ${{ github.event.pull_request.user.login }} | grep -o 'dependabot')" - - name: Check PR label - if: steps.check_author.outputs.is_dependabot != 'dependabot' + if: github.event.pull_request.user.login != 'dependabot' run: | LABEL_NAME="changelog:" if [[ $(curl -s "https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}" | jq -r '.labels[].name' | grep -c "^$LABEL_NAME") -eq 0 ]]; then