Add more time ranges #971
Merged
Add more time ranges #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgbernalp
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Add 5,15 and 30 minutes time ranges to the monitor tab Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Add 5,15 and 30 minutes time ranges to the traces search form Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
add-more-time-ranges
branch
from
3342041 to
084bbe1
Compare
albertteoh
reviewed
Jul 13, 2022
| @@ -86,7 +86,11 @@ const AdaptedVirtualSelect = reduxFormFieldAdapter({ | |||
|
|
|||
| const serviceFormSelector = formValueSelector('serviceForm'); | |||
| const oneHourInMilliSeconds = 3600000; | |||
| const fiveMinutesInMilliSeconds = 300000; | |||
There was a problem hiding this comment.
Why not do oneMinuteInMilliseconds = 60000 then values would be:
5 * oneMinuteInMilliseconds15 * oneMinuteInMilliseconds30 * oneMinuteInMilliseconds?
Comment on lines
82
to
83
| "label": "Last 5 minutes", | ||
| "value": 300000, |
There was a problem hiding this comment.
What's the reason for changing the defaults in tests?
There was a problem hiding this comment.
my bad, is fixed now.
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 95.30% 95.43% +0.13%
==========================================
Files 242 242
Lines 7554 7555 +1
Branches 1890 1837 -53
==========================================
+ Hits 7199 7210 +11
+ Misses 348 338 -10
Partials 7 7
Continue to review full report at Codecov.
|
This was referenced Jul 13, 2022
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
albertteoh
previously approved these changes
Jul 14, 2022
Comment on lines
91
to
93
| { label: 'Last 5 minutes', value: oneMinuteInMilliSeconds * 5 }, | ||
| { label: 'Last 15 minutes', value: oneMinuteInMilliSeconds * 15 }, | ||
| { label: 'Last 30 minutes', value: oneMinuteInMilliSeconds * 30 }, |
There was a problem hiding this comment.
nit: similar to those below, I would switch the operands to improve readability and consistency. i.e. 5 * oneMinuteInMilliSeconds, etc.
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
SPM:
Search form:
