Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonitorTab - fix latencies graph #934

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

nofar9792
Copy link
Contributor

@nofar9792 nofar9792 commented Apr 19, 2022

Signed-off-by: nofar9792 nofar.cohen@logz.io

Which problem is this PR solving?

Resolves #933

Short description of the changes

Reverting this line + adding test
https://github.com/jaegertracing/jaeger-ui/pull/916/files#diff-3feeebf160ae6670b08f25b846765ccd375319f7175e77067c2ffc0a817c9400R351

before:
image

after:
image

nofar9792 added 2 commits April 18, 2022 17:06
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
@nofar9792 nofar9792 changed the title Fix + test MonitorTab - fix latencies graph Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #934 (ade5d73) into main (2d91204) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   95.29%   95.50%   +0.21%     
==========================================
  Files         240      240              
  Lines        7520     7521       +1     
  Branches     1887     1888       +1     
==========================================
+ Hits         7166     7183      +17     
+ Misses        348      332      -16     
  Partials        6        6              
Impacted Files Coverage Δ
...r-ui/src/components/Monitor/ServicesView/index.tsx 97.08% <100.00%> (+0.02%) ⬆️
...mponents/TracePage/TraceStatistics/tableValues.tsx 99.31% <0.00%> (+5.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d91204...ade5d73. Read the comment docs.

@nofar9792
Copy link
Contributor Author

@yurishkuro @albertteoh

@yurishkuro yurishkuro merged commit 89a6eb1 into jaegertracing:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null metricdata in request monitor graph
2 participants