Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ddg node vis interactions #483

Merged
merged 4 commits into from
Nov 22, 2019

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • Unable to deep dive into part of DDG of interest and unable to hide part of DDG not of interest.

Short description of the changes

  • Add ability to to focus on paths through a given node.
  • Add ability to show/hide parents/children of a given node.
  • Add ability to hide a given node.

image

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #483 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   92.31%   92.47%   +0.15%     
==========================================
  Files         193      193              
  Lines        4492     4611     +119     
  Branches     1072     1101      +29     
==========================================
+ Hits         4147     4264     +117     
- Misses        303      305       +2     
  Partials       42       42
Impacted Files Coverage Δ
...ui/src/components/DeepDependencies/Graph/index.tsx 100% <ø> (ø) ⬆️
...er-ui/src/model/ddg/sample-paths.test.resources.js 100% <100%> (ø) ⬆️
...aeger-ui/src/components/DeepDependencies/index.tsx 100% <100%> (ø) ⬆️
...c/model/ddg/GraphModel/getDerivedViewModifiers.tsx 100% <100%> (ø) ⬆️
...ui/src/components/DeepDependencies/index.track.tsx 100% <100%> (ø) ⬆️
packages/jaeger-ui/src/model/ddg/PathElem.tsx 100% <100%> (ø) ⬆️
...kages/jaeger-ui/src/model/ddg/GraphModel/index.tsx 100% <100%> (ø) ⬆️
...ts/DeepDependencies/Graph/DdgNodeContent/index.tsx 100% <100%> (ø) ⬆️
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e02cb0...ebf616e. Read the comment docs.

@everett980 everett980 merged commit 5ee8da1 into jaegertracing:master Nov 22, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…eractions

Ddg node vis interactions
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants