Span Search - Improve search logic #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 16, 2018 19:30
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
added 2 commits
August 24, 2018 17:35
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 78.61% 77.03% -1.59%
==========================================
Files 135 135
Lines 2927 2952 +25
Branches 607 614 +7
==========================================
- Hits 2301 2274 -27
- Misses 495 535 +40
- Partials 131 143 +12
Continue to review full report at Codecov.
|
ghost
assigned Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 77.46% 77.05% -0.41%
==========================================
Files 135 135
Lines 2933 2951 +18
Branches 608 614 +6
==========================================
+ Hits 2272 2274 +2
- Misses 524 534 +10
- Partials 137 143 +6
Continue to review full report at Codecov.
|
|
@yurishkuro Can you merge this? I will resolve the test coverage reduction when I address test coverage, overall. |
yurishkuro
approved these changes
Sep 29, 2018
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Add result count, navigation and clear buttons Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Correct imports Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Move and delete files Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Review fixes Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Fix TracePageHeader test Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Lighten buttons when disabled Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Review fixes Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Fix tests Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add shortcuts Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Fix merge changes Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Fix TracePageHeader and TracePageSearchBar tests Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Delay TracePageHeader testing until release of Enzyme v3.5.0 Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Improve search logic Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Misc cleanup to fix a lint issue Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
TODO
"Improve search logic" is the first commit of this branch, PR will be cleaner once #234 is merged