Add timezone tooltip to custom lookback form-field #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <joef@uber.com>
tiffon
requested review from
black-adder,
vprithvi,
yurishkuro and
saminzadeh
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 92.66% 92.77% +0.11%
==========================================
Files 85 85
Lines 1881 1882 +1
Branches 366 367 +1
==========================================
+ Hits 1743 1746 +3
+ Misses 126 124 -2
Partials 12 12
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Dec 24, 2017
| on="click" | ||
| wide="very" | ||
| trigger={<i className="SearchForm--hintTrigger info circle icon grey" />} | ||
| content={<h5>Times are expressed in {tz} timezone and converted to UTC</h5>} |
There was a problem hiding this comment.
I would remove the part "and converted to UTC" from the tool tip, I don't think it's relevant to the user experience.
Signed-off-by: Joe Farro <joef@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Add timezone tooltip to custom lookback form-field Signed-off-by: Joe Farro <joef@uber.com> * Remove unnecessary info from tooltip Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #154.
EST Timezone:
PST Timezone