Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace statistics table is now using antd Table component #1500

Merged
merged 26 commits into from
Jun 19, 2023
Merged

Trace statistics table is now using antd Table component #1500

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
29f32e6
In TraceSpan table sorting indicators are also added for remaining co…
GLVSKiriti Jun 13, 2023
c21758a
Background Color of row changes according to valueNameSelector3 value…
GLVSKiriti Jun 14, 2023
9c6a827
Unnecessary files are removed
GLVSKiriti Jun 14, 2023
321f671
OnCellFunction and sorterFunction are added for TraceStatistics table
GLVSKiriti Jun 15, 2023
7b0ea15
Fixing some typo errors
GLVSKiriti Jun 15, 2023
814ce87
ISorterInput type is introduced and code is optimized
GLVSKiriti Jun 16, 2023
89b552c
Fixing typo errors
GLVSKiriti Jun 16, 2023
b82c192
Fixing typo errors and optimizing code
GLVSKiriti Jun 16, 2023
b0d2553
Merge branch 'jaegertracing:main' into traceViewsUI
GLVSKiriti Jun 16, 2023
0a79a78
Reduced the onCellFunction code
GLVSKiriti Jun 16, 2023
87392f3
Described about isDetail
GLVSKiriti Jun 16, 2023
e01d1ad
Sorter function is optimized
GLVSKiriti Jun 17, 2023
4dcec72
Optimizing the code
GLVSKiriti Jun 17, 2023
95aa95a
Describing about isDetail attribute in ITableSpan type
GLVSKiriti Jun 17, 2023
f3e386e
Removed unnecessary code snippets
GLVSKiriti Jun 17, 2023
c5d8be2
Validation checks with yarn eslint
GLVSKiriti Jun 17, 2023
aa3a8b3
Fixing the type error
GLVSKiriti Jun 17, 2023
6d5979f
Updated variable names and reduced codes
GLVSKiriti Jun 17, 2023
3eeff04
Editing isDetail attribute description in ITableSpan
GLVSKiriti Jun 17, 2023
10b66c3
Merge branch 'jaegertracing:main' into traceViewsUI
GLVSKiriti Jun 18, 2023
f8d7583
type is changed to hasSubgroupValue in ITableSpan type
GLVSKiriti Jun 18, 2023
ca881e0
Reduced code by using columnsArray to find columns
GLVSKiriti Jun 18, 2023
52450fe
Edited description for hasSubgroupValue in ITableSpan type
GLVSKiriti Jun 18, 2023
6a0fe26
run prettier
yurishkuro Jun 18, 2023
533474e
Removed testcases for functions in previous code
GLVSKiriti Jun 19, 2023
e30ecc6
yarn test,yarn lint,yarn eslint runned successfully
GLVSKiriti Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Validation checks with yarn eslint 
Modified code to remove errors

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
  • Loading branch information
@GLVSKiriti
GLVSKiriti committed Jun 17, 2023
commit c5d8be27e28d35cf02a2259a0370cf44319ee3d7
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/TracePage/TraceStatistics/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ export default class TraceStatistics extends Component<Props, State> {
return { ...val, onCell: record => onCellFunction(record) };
});

//This function adds the subgroup rows for each row according to valuenameselector2 value
// This function adds the subgroup rows for each row according to valuenameselector2 value
const findTablesAccToSelectors = (tableValue: ITableSpan[]): ITableSpan[] => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe in words what this function is doing? The name seems very non descriptive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functions makes the datasource for the antd table according to the valuenameselector values. Like it adds the child attribute for each element in datasource if we give valuenameselector2 (sub-grouping) . So this function finally outputs what are the main rows and what are the sub-group rows of each main row

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const findTablesAccToSelectors = (tableValue: ITableSpan[]): ITableSpan[] => {
/**
* Pre-process the table data into groups and sub-groups
*/
const findTablesAccToSelectors = (tableValue: ITableSpan[]): ITableSpan[] => {

const withDetail: ITableSpan[] = tableValue.filter((val: ITableSpan) => val.isDetail);
const withoutDetail: ITableSpan[] = tableValue.filter((val: ITableSpan) => !val.isDetail);
Expand Down