Remove use of react-dimensions package in ScatterPlot component
#1223
Conversation
mszabo-wikia
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
This package is abandoned and doesn't play well with Vite, because one of its dependencies uses `this` to access the global context in a way that apparently fails in a module context. Replace this dependency with a simple hooks-based implementation. Signed-off-by: Máté Szabó <mszabo@fandom.com>
mszabo-wikia
force-pushed
the
remove-react-dimensions
branch
from
81aa05a to
377a7c7
Compare
Codecov ReportBase: 95.44% // Head: 95.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
==========================================
- Coverage 95.44% 95.35% -0.09%
==========================================
Files 243 243
Lines 7570 7582 +12
Branches 1898 1901 +3
==========================================
+ Hits 7225 7230 +5
- Misses 345 352 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
So what I did here was checking the dimensions of the scatterplot in a normal situation (fullscreen window) and verifying it's properly set to an absolute value: Then I reduced the window size and verified that the scatterplot width is reduced as the window shrinks: Then I restored the original window size (fullscreen) and verified that the scatterplot expands again to fill the available width. I compared this with the behavior on an existing Jaeger 1.42 instance—the dimensions seem to match. |
…egertracing#1223) ## Which problem is this PR solving? - Split from jaegertracing#1212 ## Short description of the changes This package is abandoned and doesn't play well with Vite, because one of its dependencies uses `this` to access the global context in a way that apparently fails in a module context. Replace this dependency with a simple hooks-based implementation. Signed-off-by: Máté Szabó <mszabo@fandom.com>
Which problem is this PR solving?
Short description of the changes
This package is abandoned and doesn't play well with Vite, because one of its dependencies uses
thisto access the global context in a way that apparently fails in a module context. Replace this dependency with a simple hooks-based implementation.