Skip to content

Commit

Permalink
Exit mergeChildrenCriticalPath early for an empty critical path (#1974)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Part of #1943 

## Description of the changes
- mergeChildrenCriticalPath shortcuts for an empty critical path

## How was this change tested?
- Existing tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
  • Loading branch information
maxgaponov and yurishkuro authored Nov 13, 2023
1 parent 8b60c1d commit 7d9a325
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ function mergeChildrenCriticalPath(
spanID: string,
criticalPath: criticalPathSection[]
): criticalPathSection[] {
if (!criticalPath) {
return [];
}
// Define an array to store the IDs of the span and its descendants (if the span is collapsed)
const allRequiredSpanIds = [spanID];

Expand Down

0 comments on commit 7d9a325

Please sign in to comment.