Add zipkin.proto #56
Merged
Add zipkin.proto #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
yurishkuro
reviewed
Aug 5, 2019
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
yurishkuro
approved these changes
Aug 5, 2019
proto/zipkin.proto
Outdated
| @@ -0,0 +1,233 @@ | |||
| // https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto | |||
There was a problem hiding this comment.
nit: Copied from ... (followed by blank line)
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
|
Looks like zipkin swagger and thrift model files have been updated on upstream and we have pretty old ones. We can update them in a separate PR. |
|
Thanks. We should also add a build step as a validation of .proto files, similar to how we build from thrift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhilash Gnan abhilashgnan@gmail.com
zipkin.protofile to support sending Zipkin Protobuf spans to jaeger-collector