Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar issue on IE11 #18

Closed
jadjoubran opened this issue Aug 10, 2015 · 6 comments
Closed

Sidebar issue on IE11 #18

jadjoubran opened this issue Aug 10, 2015 · 6 comments

Comments

@jadjoubran
Copy link
Owner

Originally posted by @Bodom78 - issue #16

IE bug

I have some workarounds in the sidebar.html code for the ui-sref to work.. So this might be causing an issue on IE11..
But then I noticed that this is an upstream issue on angular/material repo:

angular/material#2131

I'm pushing a temporary fix as mentioned in this comment until the upstream issue is resolved.

@jadjoubran
Copy link
Owner Author

@Bodom78 Let me know if this works for you on IE11

@jadjoubran jadjoubran added the bug label Aug 10, 2015
@Bodom78
Copy link
Collaborator

Bodom78 commented Aug 11, 2015

Links work fine in IE, the styling issue remains.

Looks like the vertical text alignment on a list item in IE can be fixed by adding a height to md-list-item as discussed at angular/material#3764

Testing in the DOM Explorer confirms this works but it is really a hack just for IE to work. Only problem would be if you had 3 lines of text on a menu item which is unlikely.

ie-list-fix

@jadjoubran
Copy link
Owner Author

Oh okay.. that's great
I tried to see how https://material.angularjs.org/ were able to make it work in the their side-menu.. but I guess there's a line-height or padding that's making it work..
So I'm going to add a fixed height for it..

Thanks a lot for your help :D

jadjoubran pushed a commit that referenced this issue Aug 11, 2015
@jadjoubran
Copy link
Owner Author

@Bodom78 let me know if it fixes it, so I can close the issue
Thanks!

@Bodom78
Copy link
Collaborator

Bodom78 commented Aug 11, 2015

Looks good and working fine in IE11 now.

@jadjoubran
Copy link
Owner Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants