Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog is not working when minify css #144

Closed
kiro64 opened this issue Jan 19, 2016 · 6 comments
Closed

Dialog is not working when minify css #144

kiro64 opened this issue Jan 19, 2016 · 6 comments
Labels
Milestone

Comments

@kiro64
Copy link

kiro64 commented Jan 19, 2016

i saw this project on version 3 have change css minify to use gulp-cssnano.
this cause an issue on "Confirm Dialog" can not interact with user, ( can not click on any button and need to press "esc" on key board to close a dialog)

anyone have a solution on this problem?

@jadjoubran
Copy link
Owner

@kiro64 did you check your console for javascript errprs?
If you try to insect element does the button seem clickable? or is it covered by other elements?

It's not really an issue with this starter package but we can keep it open for a bit if anyone has a solution

@kiro64
Copy link
Author

kiro64 commented Jan 20, 2016

there's no error in console because it's css problem. Actually, it's have a problem with all Dialog Type.
The problem come up when i run gulp --production to minify css and deploy project on production.

i'm turn back to gulp-minify-css with no problem for a while.

@jadjoubran
Copy link
Owner

@kiro64 would you be able to provide a codepen to test this?
It would be useful especially if it's something that might affect other users
Thanks!

@jadjoubran jadjoubran added bug and removed Support labels Jan 23, 2016
@jadjoubran
Copy link
Owner

Hi @kiro64
Thanks for reporting this, I was able to reproduce it
I'm reverting to gulp-minify-css

@jadjoubran
Copy link
Owner

It seems that in elixir 4.2 unsafe cssnano optimizations were disabled
I'll give this is a shot and see if it works
https://www.npmjs.com/package/laravel-elixir#421

@jadjoubran jadjoubran reopened this Mar 31, 2016
@jadjoubran jadjoubran added this to the Version 3.2 milestone Mar 31, 2016
@jadjoubran
Copy link
Owner

Also confirmed by @bampakoa's post.. I just saw it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants