Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma tests setup for Angular #117

Closed
jadjoubran opened this issue Dec 17, 2015 · 10 comments
Closed

Karma tests setup for Angular #117

jadjoubran opened this issue Dec 17, 2015 · 10 comments

Comments

@jadjoubran
Copy link
Owner

Current repo is missing setup for Angular unit tests using ngAnnotate

@kujtimiihoxha
Copy link
Contributor

@jadjoubran Is there any work being done on this issue, it would be really nice to have tests in the next release. Thanks.

@jadjoubran
Copy link
Owner Author

@kujtimiihoxha unfortunately this is not planned for the next release since there are more critical features.. especially JWT and everything around it

However feel free to submit a Pull Request for this

@kujtimiihoxha
Copy link
Contributor

@jadjoubran I have tried to implement karma tests but did not succeed, I will try again to implement this feature in the coming days, as soon as I have it ready I will submit a Pull Request .

@kujtimiihoxha
Copy link
Contributor

@jadjoubran look at PR #219

@kujtimiihoxha
Copy link
Contributor

@jadjoubran Tell me if you have any tests in mind and I will implement them ;).

@jadjoubran
Copy link
Owner Author

Thanks again 😄

Actually I just remembered that it would make sense to setup ngDescribe on top of this.. since it removes all the boilerplate
I can help you with it if you want

@jadjoubran jadjoubran added this to the Version 3.2 milestone Mar 25, 2016
@kujtimiihoxha
Copy link
Contributor

I will see what I can do, I will try to implement this today.

@kujtimiihoxha
Copy link
Contributor

@jadjoubran tests can now use ngDescribe ;) tell me what you think about the folder structure I proposed and I will implement that ;)

@jadjoubran
Copy link
Owner Author

@kujtimiihoxha thank you so much
I think we're almost done 😄 just a few minor fixes

@kujtimiihoxha
Copy link
Contributor

@jadjoubran All done, take a look at my commit, tell me if there is anything else needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants