fix: use native abort controller if available #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environments like Electron's Renderer process have native browser APIs available but don't respect the `browser` field in `package.json`. You also don't always want to use 100% browser or 100% node APIs depending on your application, so don't make the user choose all or nothing. Here we switch out `abort-controller` for `native-abort-controller` which will return the native abort controller if it's available, or the `abort-controller` polyfill if it is not.
|
This bubbles up to ipfs/js-ipfs#3251 |
|
..and also addresses #3 (comment) |
|
Published as 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments like Electron's Renderer process have native browser APIs available but don't respect the
browserfield inpackage.json.You also don't always want to use 100% browser or 100% node APIs depending on your application, so don't make the user choose all or nothing.
Here we switch out
abort-controllerfornative-abort-controllerwhich will return the native abort controller if it's available, or theabort-controllerpolyfill if it is not.