Fix unit test error that caused test to break; fix salesforce#231 by writing the file as utf-8 by default even for windows

Author: kmcquade

cloudsplaining/command/scan.py

@@ -115,7 +115,7 @@ def scan(
         if os.path.exists(html_output_file):
             os.remove(html_output_file)
 
-        with open(html_output_file, "w") as f:
+        with open(html_output_file, "w", encoding="utf-8") as f:
             f.write(rendered_html_report)
 
         print(f"Wrote HTML results to: {html_output_file}")

docs/_images/cloudsplaining-report.gif

@@ -5,9 +5,7 @@ verbosity=2
 
 [tool:pytest]
 testpaths = test test/command test/scanning test/output test/shared
-verbosity=2
 python_files=test/*/test_*.py
-ignore= __pycache__ *.pyc
 norecursedirs = .svn _build tmp* __pycache__
 
 # Exclude: __pycache__ / .pyc

setup.cfg

@@ -122,7 +122,7 @@ def test_all_allowed_unrestriced_deny(self):
         }
         policy_document = PolicyDocument(test_policy)
         result = policy_document.all_allowed_unrestricted_actions
-        self.assertEquals([],result)
+        self.assertEqual([],result)
 
     def test_policy_document_all_allowed_actions_deny(self):
         """scan.policy_document.all_allowed_actions"""

test/scanning/test_policy_document.py

@@ -1,4 +1,5 @@
 import unittest
+import json
 from cloudsplaining.scan.statement_detail import StatementDetail
 from cloudsplaining.shared.exclusions import is_name_excluded, Exclusions, DEFAULT_EXCLUSIONS
 
@@ -184,7 +185,6 @@ def test_statement_details_for_allow_not_action(self):
         results = statement.not_action_effective_actions
         # We excluded everything else besides TagResource on purpose. Not a typical pattern
         # but easier to maintain with unit tests
-        import json
         print(json.dumps(results, indent=4))
         # Future proofing this unit test
         expected_actions = [
@@ -227,7 +227,7 @@ def test_statement_details_for_allow_not_action(self):
         this_statement = {
             "Sid": "VisualEditor0",
             "Effect": "Deny",
-            "NotAction": [
+            "Action": [
                 "iam:*",
             ],
             "Resource": [
@@ -243,7 +243,7 @@ def test_statement_details_for_allow_not_action(self):
         this_statement = {
             "Sid": "VisualEditor0",
             "Effect": "Deny",
-            "NotAction": [
+            "Action": [
                 "iam:*",
             ],
             "Resource": [