Order of Map and Set entries reversed in v2

[bjohn465]

In the latest v2 version of turbo-stream (currently v2.4.1), encoding and decoding a Map or Set object results in a Map or Set with the order of entries reversed. Since Map and Set are specified to iterate over their entries in insertion order, the decoded object does not iterate in the same order that the original, encoded object does.

In the latest v3 version (currently v3.1.0), Map and Set objects decode with the entries in the correct order.

Since v3 changed the encoding format, some applications may not be able to upgrade to v3 very quickly. What is the possibility of a v2 release that would fix the Map and Set entry order problem? Does the answer change at all if someone creates and submits a pull request that fixes the issue?

[bjohn465]

I put together a commit with a potential fix for the issue: bjohn465@536c948

[brophdawg11]

Shoot - sorry I didn't see this issue or your fix before I took a stab at it! I I tried your approach locally too and it broke for me but maybe I had an off by one error (I probably missed the length - 2 aspect tbh). I like that solution much better than mine so I'll ping Jacob to use that one. He's on vacation currently so might not be right away.

[brophdawg11]

We're fixing this in remix-run/react-router#13518 - I pulled in your fix to that PR 👍 . Should be available in the next RR release

[brophdawg11]

@jacob-ebey I don't have permissions to close this issue 🙃