Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikilinks to headings starting with links break callouts #1536

Open
Tracked by #1496
tinygwen opened this issue Oct 21, 2024 · 1 comment
Open
Tracked by #1496

wikilinks to headings starting with links break callouts #1536

tinygwen opened this issue Oct 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tinygwen
Copy link

tinygwen commented Oct 21, 2024

Describe the bug
wikilinks to headings starting with external links break callouts

To Reproduce
create a headings with an external link, ex # [wikipedia](https://wikipedia.org)
create a callout with a wikilink to that section (headings)
this breaks titles and bodies of both parent and nested callouts

I've created an example markdown document for this issue which demonstrates the bug.

here is the raw content of both title and body of both parent and nested callouts which can be pasted into an .md as demonstration:

>[!bug]- Test text [[wikilinks to headings starting with links break callouts#[headings that's an external link ( 3)](https //www.wikipedia.org/)|wikilink]]
>Test text [[wikilinks to heading starting with links break callouts#[headings that's an external link ( 3)](https //www.wikipedia.org/)|wikilink]]
>> [!bug]- Test text [[wikilinks to heading starting with links break callouts#[Heading that's an external link ( 3)](https //www.wikipedia.org/)|wikilink]]
>> Test text [[wikilinks to headings starting with links break callouts#[Heading that's an external link ( 3)](https //www.wikipedia.org/)|wikilink]]

# [Heading that's an external link (#3)](https://www.wikipedia.org/)
~~to wikipedia as an example, for issue 3~~
i decided to seperate into multiple bug reports but i'm leaving this title here, as i imagine the hash could also be problematic

Expected behavior
callouts ought to be able to handle wikilinking to a section/heading that contains/begins with a an external link

Screenshots and Source
Expected behavior, as handled in obsidian:

You can help speed up fixing the problem by either

  1. providing a simple reproduction
  2. linking to your Quartz repository where the problem can be observed
    I've created an example markdown document for this issue which demonstrates the bug.

Desktop (please complete the following information):

  • Quartz Version: 4.4.0
  • node Version:
    vscode: 20.11.1
    deploy.yml: 22
    //note that this issue occurs when hosted on github-pages and localhost
  • npm version: 10.2.4
    //note that this issue occurs when hosted on github-pages and localhost
  • OS: Fedora Linux
  • Browser Brave

Additional context
i have not tested if the heading being a wikilink also breaks the callout.
i have left the # in the heading as well

@tinygwen tinygwen added the bug Something isn't working label Oct 21, 2024
@saberzero1
Copy link
Collaborator

I'm not sure if I'm more impressed that you found this, or that the Obsidian devs accounted for this.

Repository owner deleted a comment Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants