From dc2ec2823ab9d456f9fef8739ef8b0c6f2459170 Mon Sep 17 00:00:00 2001
From: Ewan Chou <coocood@gmail.com>
Date: Sat, 21 Jan 2017 14:12:07 +0800
Subject: [PATCH] store/tikv: add log for slow coprocessor task (#2524)

---
 store/tikv/backoff.go        |  9 +++++++++
 store/tikv/coprocessor.go    | 21 +++++++++++++++++----
 store/tikv/region_request.go |  2 ++
 3 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/store/tikv/backoff.go b/store/tikv/backoff.go
index 6652d045f70e9..104cd59b0c5e2 100644
--- a/store/tikv/backoff.go
+++ b/store/tikv/backoff.go
@@ -133,6 +133,7 @@ type Backoffer struct {
 	totalSleep int
 	errors     []error
 	ctx        context.Context
+	types      []backoffType
 }
 
 // NewBackoffer creates a Backoffer with maximum sleep time(in ms).
@@ -165,6 +166,7 @@ func (b *Backoffer) Backoff(typ backoffType, err error) error {
 	}
 
 	b.totalSleep += f()
+	b.types = append(b.types, typ)
 
 	log.Debugf("%v, retry later(totalSleep %dms, maxSleep %dms)", err, b.totalSleep, b.maxSleep)
 	b.errors = append(b.errors, err)
@@ -181,6 +183,13 @@ func (b *Backoffer) Backoff(typ backoffType, err error) error {
 	return nil
 }
 
+func (b *Backoffer) String() string {
+	if b.totalSleep == 0 {
+		return ""
+	}
+	return fmt.Sprintf(" backoff(%dms %#s)", b.totalSleep, b.types)
+}
+
 // Fork creates a new Backoffer which keeps current Backoffer's sleep time and errors.
 func (b *Backoffer) Fork() *Backoffer {
 	return &Backoffer{
diff --git a/store/tikv/coprocessor.go b/store/tikv/coprocessor.go
index 7d13fccd83ac9..ace4f3423fdeb 100644
--- a/store/tikv/coprocessor.go
+++ b/store/tikv/coprocessor.go
@@ -116,9 +116,15 @@ type copTask struct {
 	region RegionVerID
 	ranges *copRanges
 
-	status   int
-	idx      int // Index of task in the tasks slice.
-	respChan chan *coprocessor.Response
+	status    int
+	idx       int // Index of task in the tasks slice.
+	respChan  chan *coprocessor.Response
+	storeAddr string
+}
+
+func (r *copTask) String() string {
+	return fmt.Sprintf("region(%d %d %d) ranges(%d) store(%s)",
+		r.region.id, r.region.confVer, r.region.ver, r.ranges.len(), r.storeAddr)
 }
 
 // copRanges is like []kv.KeyRange, but may has extra elements at head/tail.
@@ -301,6 +307,8 @@ type copIterator struct {
 	errChan  chan error
 }
 
+const minLogCopTaskTime = 50 * time.Millisecond
+
 // Pick the next new copTask and send request to tikv-server.
 func (it *copIterator) work() {
 	for {
@@ -326,7 +334,11 @@ func (it *copIterator) work() {
 		bo := NewBackoffer(copNextMaxBackoff, context.Background())
 		startTime := time.Now()
 		resp, err := it.handleTask(bo, task)
-		coprocessorHistogram.Observe(time.Since(startTime).Seconds())
+		costTime := time.Since(startTime)
+		if costTime > minLogCopTaskTime {
+			log.Infof("[TIME_COP_TASK] %s%s %s", costTime, bo, task)
+		}
+		coprocessorHistogram.Observe(costTime.Seconds())
 		if bo.totalSleep > 0 {
 			backoffHistogram.Observe(float64(bo.totalSleep) / 1000)
 		}
@@ -464,6 +476,7 @@ func (it *copIterator) handleTask(bo *Backoffer, task *copTask) (*coprocessor.Re
 			log.Warnf("coprocessor err: %v", err)
 			return nil, errors.Trace(err)
 		}
+		task.storeAddr = sender.storeAddr
 		return resp, nil
 	}
 }
diff --git a/store/tikv/region_request.go b/store/tikv/region_request.go
index 639a0f04283a2..badd9dd9409af 100644
--- a/store/tikv/region_request.go
+++ b/store/tikv/region_request.go
@@ -42,6 +42,7 @@ type RegionRequestSender struct {
 	bo          *Backoffer
 	regionCache *RegionCache
 	client      Client
+	storeAddr   string
 }
 
 // NewRegionRequestSender creates a new sender.
@@ -118,6 +119,7 @@ func (s *RegionRequestSender) SendCopReq(req *coprocessor.Request, regionID Regi
 			}, nil
 		}
 
+		s.storeAddr = ctx.Addr
 		resp, retry, err := s.sendCopReqToRegion(ctx, req, timeout)
 		if err != nil {
 			return nil, errors.Trace(err)