Load from submodule gets wrong package.json

[iliakan]

I wrote a module (gulp task) which uses gulp-load-plugins().

When this module is installed and used by the "Main app", findup looks for package.json in cwd, that is the main app's working directory, and it tries to load plugins for the main app instead.

Takes more time and actually main app has another set of plugins, so that's just wrong.

Solved it like this:

const gp = require('gulp-load-plugins')({
  config: path.join(__dirname, 'package.json')
});

I wonder if there's a better way of searching package.json?

[jackfranklin]

Hey @iliakan,

Can you give me a bit more detail please? I don't fully understand the problem. Could you explain your project's directory structure and how everything is laid out, and hence what the plugin is doing wrong?

In the mean time, your solution is spot on at least, so at least it's working. If I can improve the behaviour then I'm all for it but could do with some more info :)

[iliakan]

The app structure:

  - app
  - gulpfile.js
  - package.json (1)
  - node_modules
    - my-gulp-plugin
      - index.js     <--
      - package.json (2)
      - node_modules
        - gulp-load-plugins

When I use gulp-load-plugin in my-gulp-plugin/index.js, it resolves package.json (1), not (2).

[iliakan]

P.S. More details: I run gulp from directory app, it requires my-gulp-plugin which in turn uses gulp-load-plugin, which resolves package.json to (1), not (2).

[jackfranklin]

Okay, so it basically should try looking in the current directory of the file it's invoked from first, and if not, use the process.cwd? I think that's doable.

[iliakan]

How will you get the file it's invoked from?

The one way I can imagine is gulp-plugin-loader(module)

[jackfranklin]

Yeah, you'd have to pass something through.

To be honest, as you're the first to come up with this problem, I don't think it's worth pushing a specific fix for it, as it's clearly not something the majority of users do. You managed to find a solution using the config option (which is exactly why it's there), so unless a lot of folk start running into this, I'm reluctant to push a specific fix.

[iliakan]

Fine then, please let others know about this pecularity by accepting my small PR. Closing this.

[flovan]

Thought I'd let you know that I had an issue with this as well.

I am using a custom CLI, which runs from the ./bin folder and passes tasks through to a required gulpfile, ./gulpfile.js. When I run gulp-plugin-loader with the default settings, the package.json that gets loaded is the one of the module itself, rather than the one of my project.
I managed to fix it through the config option as well, though I will be replacing my ../../package.json with @iliakan's solution.

[iliakan]

Maybe module.parent could help? We could search from path.dirname(module.parent.__filename) or kind of...

[jackfranklin]

That sounds promising - whilst this is clearly something most people don't come across I'd be very willing to merge in a PR if someone wants to investigate this further :)

[flovan]

Or you could default to path.join(__dirname, 'package.json') and keep the rest as is. I think that would cover this reported issue (and hopefully not spawn others).
Anyway, I don't have time atm to dive into this, especially since it can be fixed quite easily through config.