Fix *dbTx.Exec not checking if it is already closed

jackc · jackc · commit 7d882f9aa7b3 · 2024-02-23T18:02:28.000-06:00
#1908
diff --git a/tx.go b/tx.go
@@ -264,6 +264,10 @@ func (tx *dbTx) Rollback(ctx context.Context) error {
 
 // Exec delegates to the underlying *Conn
 func (tx *dbTx) Exec(ctx context.Context, sql string, arguments ...interface{}) (commandTag pgconn.CommandTag, err error) {
+	if tx.closed {
+		return pgconn.CommandTag{}, ErrTxClosed
+	}
+
 	return tx.conn.Exec(ctx, sql, arguments...)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -264,6 +264,10 @@ func (tx *dbTx) Rollback(ctx context.Context) error {`
`264`	`264`
`265`	`265`	`// Exec delegates to the underlying *Conn`
`266`	`266`	`func (tx *dbTx) Exec(ctx context.Context, sql string, arguments ...interface{}) (commandTag pgconn.CommandTag, err error) {`
	`267`	`+ if tx.closed {`
	`268`	`+ return pgconn.CommandTag{}, ErrTxClosed`
	`269`	`+ }`
	`270`	`+`
`267`	`271`	`return tx.conn.Exec(ctx, sql, arguments...)`
`268`	`272`	`}`
`269`	`273`