Fix noexcept audit issues

Author: j4james

src/terminal/adapter/SixelParser.cpp

@@ -712,20 +712,20 @@ void SixelParser::_fillImageBackgroundWhenScrolled()
     if (_filledBackgroundHeight && imageHeight > _filledBackgroundHeight) [[unlikely]]
     {
         _filledBackgroundHeight = (imageHeight + _cellSize.height - 1) / _cellSize.height * _cellSize.height;
-        const auto additionalFillHeight = _filledBackgroundHeight.value() - _imageCursor.y;
+        const auto additionalFillHeight = *_filledBackgroundHeight - _imageCursor.y;
         _resizeImageBuffer(additionalFillHeight);
         _fillImageBackground(additionalFillHeight);
     }
 }
 
-void SixelParser::_decreaseFilledBackgroundHeight(const int decreasedHeight)
+void SixelParser::_decreaseFilledBackgroundHeight(const int decreasedHeight) noexcept
 {
     // Sometimes the top of the image buffer may be clipped (e.g. when the image
     // scrolls off the top of a margin area). When that occurs, our record of
     // the filled height will need to be decreased to account for the new start.
     if (_filledBackgroundHeight) [[unlikely]]
     {
-        _filledBackgroundHeight = _filledBackgroundHeight.value() - decreasedHeight;
+        _filledBackgroundHeight = *_filledBackgroundHeight - decreasedHeight;
     }
 }
 

src/terminal/adapter/SixelParser.hpp

@@ -112,7 +112,7 @@ namespace Microsoft::Console::VirtualTerminal
         void _fillImageBackground();
         void _fillImageBackground(const int backgroundHeight);
         void _fillImageBackgroundWhenScrolled();
-        void _decreaseFilledBackgroundHeight(const int decreasedHeight);
+        void _decreaseFilledBackgroundHeight(const int decreasedHeight) noexcept;
         void _writeToImageBuffer(const int sixelValue, const int repeatCount);
         void _eraseImageBufferRows(const int rowCount, const til::CoordType startRow = 0) noexcept;
         void _maybeFlushImageBuffer(const bool endOfSequence = false);