Fix Node hook installation with npm 11

[j178]

npm 11's global Git install can remove the hook package while child dependencies are still being extracted. Pack remote Node hooks first and install the resulting tarball instead.

Keep direct Git installation with --allow-git=root on npm 12, where npm pack loses the root classification.

Related pre-commit/pre-commit#3737

[codecov]

Codecov Report

❌ Patch coverage is 88.76404% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.59%. Comparing base (c2da01b) to head (9cf8b44).

Files with missing lines	Patch %	Lines
crates/prek/src/languages/node/node.rs	88.76%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2487      +/-   ##
==========================================
- Coverage   93.60%   93.59%   -0.02%     
==========================================
  Files         131      131              
  Lines       28215    28275      +60     
==========================================
+ Hits        26410    26463      +53     
- Misses       1805     1812       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR adjusts how prek installs remote Node hook repositories to be compatible with npm 11’s global Git installation behavior, while keeping npm 12’s --allow-git=root flow and expanding tests to validate both runtime and prepare-time dependency scenarios.

Changes:

• Introduce an npm < 12 installation path that runs npm pack on the Git hook repo and installs the resulting tarball globally (avoids npm 11 reifier issues).
• Keep direct global Git installation on npm >= 12 with --allow-git=root for the hook repo.
• Strengthen Node language tests to cover runtime dependencies and ensure prepare can use devDependencies across supported npm versions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/prek/src/languages/node/node.rs	Refactors Node dependency installation into an Npm helper, adding a npm pack tarball path for npm < 12 and keeping direct Git installs for npm >= 12.
crates/prek/tests/languages/node.rs	Updates remote Node hook tests to exercise runtime deps and removes npm-version gating for the devDependency/prepare test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cf8b44b19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[prek-ci-bot]

📦 Cargo Bloat Comparison

Binary size change: +0.68% (29.6 MiB → 29.8 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  84.6KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  57.5KiB              prek prek::run::{closure#0}
 0.2%   0.4%  55.9KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.1%   0.3%  38.6KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.2%  34.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  32.8KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.9KiB              prek <prek::languages::deno::installer::DenoInstaller>::download::{closure#0}
 0.1%   0.2%  25.4KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.0KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.2KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.0KiB     granit_parser <granit_parser::scanner::Scanner<serde_saphyr::de::buffered_input::ReaderInput>>::fetch_more_tokens
42.4%  88.2%  12.6MiB                   And 26396 smaller methods. Use -n N to show more.
48.1% 100.0%  14.3MiB                   .text section size, the file size is 29.8MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.2%   0.5%  70.9KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  58.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.4%  56.6KiB              prek prek::run::{closure#0}
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.1%   0.3%  38.4KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.2%  34.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  33.5KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  29.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.9KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.7KiB              prek <prek::languages::node::installer::NodeInstaller>::install::{closure#0}
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.9KiB              prek <prek::languages::deno::installer::DenoInstaller>::download::{closure#0}
 0.1%   0.2%  25.7KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.6KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  25.2KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
42.3%  88.2%  12.5MiB                   And 26309 smaller methods. Use -n N to show more.
47.9% 100.0%  14.2MiB                   .text section size, the file size is 29.6MiB

[prek-ci-bot]

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

• OS: Linux 6.17.0-1020-azure
• CPU: 4 cores
• prek version: prek 0.4.12+7 (68fc74a 2026-08-06)
• Rust version: rustc 1.97.1 (8bab26f4f 2026-07-14)
• Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base --version	2.2 ± 0.1	2.0	2.6	1.02 ± 0.07
prek-head --version	2.2 ± 0.1	2.0	2.6	1.00

prek list

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base list	9.5 ± 0.2	9.1	10.2	1.00
prek-head list	9.6 ± 0.4	9.1	12.5	1.01 ± 0.05

prek validate-config .pre-commit-config.yaml

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base validate-config .pre-commit-config.yaml	3.2 ± 0.1	3.1	3.4	1.01 ± 0.03
prek-head validate-config .pre-commit-config.yaml	3.2 ± 0.1	3.0	3.4	1.00

prek sample-config

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base sample-config	2.5 ± 0.0	2.4	2.6	1.00
prek-head sample-config	2.5 ± 0.1	2.4	2.7	1.02 ± 0.04

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	39.0 ± 1.6	36.8	41.9	1.00
prek-head run --all-files	40.0 ± 1.3	38.4	42.0	1.03 ± 0.05

prek run --all-files (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	39.6 ± 1.4	36.8	41.7	1.00 ± 0.05
prek-head run --all-files	39.5 ± 1.2	37.8	41.3	1.00

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	39.3 ± 1.0	37.1	41.2	1.00
prek-head run --all-files	39.5 ± 1.1	37.3	41.6	1.00 ± 0.04

Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run trailing-whitespace --all-files	13.3 ± 0.4	12.7	14.1	1.00 ± 0.04
prek-head run trailing-whitespace --all-files	13.3 ± 0.4	12.6	14.5	1.00

prek run end-of-file-fixer --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run end-of-file-fixer --all-files	11.0 ± 0.5	10.4	12.1	1.00
prek-head run end-of-file-fixer --all-files	11.1 ± 0.4	10.5	12.0	1.01 ± 0.06

prek run check-json --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-json --all-files	7.7 ± 0.3	7.3	8.6	1.00
prek-head run check-json --all-files	7.8 ± 0.2	7.3	8.2	1.01 ± 0.05

prek run check-yaml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-yaml --all-files	7.6 ± 0.1	7.3	7.9	1.00
prek-head run check-yaml --all-files	7.6 ± 0.2	7.3	8.0	1.00 ± 0.03

prek run check-toml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-toml --all-files	7.9 ± 0.3	7.4	8.6	1.00
prek-head run check-toml --all-files	7.9 ± 0.3	7.4	8.9	1.00 ± 0.06

prek run check-xml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-xml --all-files	7.8 ± 0.5	7.2	8.9	1.01 ± 0.08
prek-head run check-xml --all-files	7.7 ± 0.4	7.2	8.9	1.00

prek run detect-private-key --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run detect-private-key --all-files	11.2 ± 0.7	9.9	13.0	1.01 ± 0.09
prek-head run detect-private-key --all-files	11.1 ± 0.6	10.2	12.9	1.00

prek run fix-byte-order-marker --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run fix-byte-order-marker --all-files	13.1 ± 0.8	11.5	14.7	1.00
prek-head run fix-byte-order-marker --all-files	13.2 ± 0.6	12.1	14.4	1.01 ± 0.08

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.4 ± 0.1	4.3	4.6	1.00 ± 0.03
prek-head install-hooks	4.4 ± 0.0	4.4	4.4	1.00

prek install-hooks (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.5 ± 0.1	4.4	4.6	1.01 ± 0.02
prek-head install-hooks	4.5 ± 0.0	4.4	4.5	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run	23.8 ± 0.5	23.1	25.2	1.00
prek-head run	23.9 ± 0.4	23.3	24.9	1.01 ± 0.02

prek run --files '*.json' (specific file type)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --files '*.json'	5.2 ± 0.2	5.0	5.7	1.02 ± 0.04
prek-head run --files '*.json'	5.1 ± 0.1	5.0	5.2	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --dry-run --all-files	6.9 ± 0.2	6.7	7.5	1.01 ± 0.03
prek-head run --dry-run --all-files	6.9 ± 0.1	6.7	7.2	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-hooks-apply --all-files	8.2 ± 0.1	8.0	8.4	1.00
prek-head run check-hooks-apply --all-files	8.3 ± 0.3	8.1	9.2	1.02 ± 0.04

prek run check-useless-excludes --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-useless-excludes --all-files	8.2 ± 0.1	7.9	8.4	1.01 ± 0.02
prek-head run check-useless-excludes --all-files	8.1 ± 0.1	8.0	8.2	1.00

prek run identity --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run identity --all-files	7.1 ± 0.2	6.9	7.8	1.02 ± 0.04
prek-head run identity --all-files	7.0 ± 0.1	6.9	7.1	1.00