Skip to content

Stop checking for only http #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Node-MPV-2
Choose a base branch
from

Conversation

NolanCassidy
Copy link
Contributor

No description provided.

@j-holub
Copy link
Owner

j-holub commented Jul 17, 2021

Where's the part, where file paths are transformed to absolute paths, such that it works, no matter from which path Node-MPV was started?
I get that checking for HTTP only might not be the best idea and it needs to be changed, but removing the transformation to absolute paths for file paths is not the way to do this in my opinion.

Furthermore, if you delete a line of code, might as well delete the 3-line comment that explains what it does : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants