Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on IOS: Property 'doneButtonColor' not found on object of type 'TOCropViewController' #1954

Open
lukeharvey opened this issue Jul 25, 2023 · 8 comments

Comments

@lukeharvey
Copy link

Version

Tell us which versions you are using:

  • react-native-image-crop-picker v0.40.0
  • react-native v0.72.1

Platform

Tell us to which platform this issue is related

  • iOS

Expected behaviour

The app should build successfully in XCode (14.3.1)

Actual behaviour

I am unable to build our app. I get the following errors:

In .../node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m:904:20
Property 'doneButtonColor' not found on object of type 'TOCropViewController *'; did you mean 'doneButtonTitle'?

In ...node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m:907:20
Property 'cancelButtonColor' not found on object of type 'TOCropViewController *'; did you mean 'cancelButtonTitle'?

Screenshot 2023-07-25 at 11 05 52 AM

I believe the issue is related to the new functionality added in #1923

I also believe you might be missing the following additions to TOCropViewController.h

@property (nullable, nonatomic, copy) NSString *doneButtonColor;

@property (nullable, nonatomic, copy) NSString *cancelButtonColor;

which seems to fix the issue for me

Steps to reproduce

  1. Update to v0.40.0

  2. Try to build the app

Attachments

// stacktrace or any other useful debug info

Love react-native-image-crop-picker? Please consider supporting our collective:
👉 https://opencollective.com/react-native-image-crop-picker/donate

@FZYdesign
Copy link

same issues!

@Etaliya
Copy link

Etaliya commented Jul 28, 2023

Any Update? Issue is still present in V0.40.0

@RushitaBacancy
Copy link

Same issue in 0.40.0

@manuelbieh
Copy link

manuelbieh commented Sep 19, 2023

Had the same issue. Delete the following line from your ios/Podfile.lock and run yarn install && npx pod-install again.

  - TOCropViewController (2.5.3)

@MoeMamdouh
Copy link

Same issue here

@skizzo
Copy link

skizzo commented Nov 2, 2023

After reverting to version 0.39.0, building on iOS works again for me. With the latest version (0.40.1 at the time of writing this), it doesn't.

@charlyBerthet
Copy link

charlyBerthet commented Nov 3, 2023

Cannot build version 0.40.1. pod deintegrate + pod install does not change anything.

I figured out that I am also using another lib that uses TOCropViewController (react-native-image-crop-tools) but in version (2.5.3). So it forces the use of an older version that doesn't yet have the property doneButtonColor.

Basic deps conflicts

@Seokkitdo
Copy link

@charlyBerthet

Cannot build version 0.40.1. pod deintegrate + pod install does not change anything.

I figured out that I am also using another lib that uses TOCropViewController (react-native-image-crop-tools) but in version (2.5.3). So it forces the use of an older version that doesn't yet have the property doneButtonColor.

Basic deps conflicts

Did you solve that problem using those two libs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants