Remove previously chained models from choices & fix circular deps #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove chained models from choices. The condition on the backend side was applied to avoid circular deps. https://github.com/ivelum/djangoql/blob/master/djangoql/schema.py#L372 This changes appeared after pull request ivelum/djangoql@3e2ca75#diff-f67209e7ff98d18b4b4304fff7b422244b54a19233e58fa37e8bd2cf29cadaaeR355 This pull request can be merged ivelum/djangoql#77
To support saving chains of models after and/or operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've prepared the fix for removing chained models from choices and fixing circular dependencies.
The condition on the backend side was applied to avoid circular dependencies.
https://github.com/ivelum/djangoql/blob/master/djangoql/schema.py#L372
These changes appeared after this pull request ivelum/djangoql@3e2ca75#diff-f67209e7ff98d18b4b4304fff7b422244b54a19233e58fa37e8bd2cf29cadaaeR355
Pay attention, that this pull request can be merged ivelum/djangoql#77 after applying changes from my pull request.
Thanks,
Denis