From ed53bea189fb39910e91c166663c403c4dfc08b9 Mon Sep 17 00:00:00 2001 From: Kyle Milloy Date: Tue, 15 Nov 2016 00:06:50 -0700 Subject: [PATCH] fix for issue #2 --- CHANGELOG.md | 25 ++++++++++++++++--------- VideoPlayer.js | 17 +++++++++-------- assets/img/bottom-vignette.png | Bin 994 -> 976 bytes assets/img/bottom-vignette@2x.png | Bin 1079 -> 1047 bytes assets/img/bottom-vignette@3x.png | Bin 1228 -> 1151 bytes assets/img/top-vignette.png | Bin 997 -> 990 bytes assets/img/top-vignette@2x.png | Bin 1082 -> 1053 bytes assets/img/top-vignette@3x.png | Bin 1220 -> 1170 bytes index.ios.js | 2 +- 9 files changed, 26 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e08957..bbb65ba 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,9 +1,16 @@ -# Change Log - -## 0.9.5 (14-11-2016) -Bug fixes: -[Tapping controls doesn't reset control hide timeout](https://github.com/itsnubix/react-native-video-controls/issues/1) - - add resets to panhandlers for volume/seek areas - - add resets to renderControl function onPress params. -Features: - - Added loading icon +## 0.9.5 (15-11-2016) + +### Bug fixes +[Tapping controls doesn't reset control hide timeout](https://github.com/itsnubix/react-native-video-controls/issues/1): + + - add resets to panhandlers for volume/seek areas + - add resets to renderControl function onPress params. + +[Control backgrounds should be gradients](https://github.com/itsnubix/react-native-video-controls/issues/2) + + - Changed vignette assets to be more subtle. + - Added stretch to resizeMode + +### Features: + +- Added loading icon diff --git a/VideoPlayer.js b/VideoPlayer.js index 9ba4ad8..423cf78 100644 --- a/VideoPlayer.js +++ b/VideoPlayer.js @@ -89,7 +89,8 @@ export default class VideoPlayer extends Component { this.player = { volumePanResponder: PanResponder, seekPanResponder: PanResponder, - controlTimeoutDelay: 10000, + //controlTimeoutDelay: 10000, CHANGEBACK + controlTimeoutDelay: 10000000, controlTimeout: null, volumeWidth: 150, seekWidth: 0, @@ -979,6 +980,8 @@ const styles = { container: { flex: 1, alignSelf: 'stretch', + backfaceVisibility: 'hidden', + justifyContent: 'space-between', }, video: { position: 'absolute', @@ -998,9 +1001,6 @@ const styles = { alignItems: 'center', justifyContent: 'center', }, - icon: { - - }, }), controls: StyleSheet.create({ row: { @@ -1017,8 +1017,9 @@ const styles = { height: null, width: null, }, - background: { - resizeMode: 'repeat', + vignette: { + resizeMode: 'stretch', + backfaceVisibility: 'hidden', }, control: { padding: 24, @@ -1052,7 +1053,7 @@ const styles = { justifyContent: 'center', zIndex: 100, marginTop: 24, - marginBottom: -10, + marginBottom: 0, marginLeft: 12, marginRight: 12, }, @@ -1070,7 +1071,7 @@ const styles = { alignItems: 'center', justifyContent: 'space-between', flexDirection: 'row', - marginBottom: -10, + marginBottom: 0, marginLeft: 18, marginRight: 18, }, diff --git a/assets/img/bottom-vignette.png b/assets/img/bottom-vignette.png index 6b6f7e15fa0ef13055ebb90fa2a6aa09b9b6675d..afbd30eae11348eafe93683104f607481fac61b2 100644 GIT binary patch delta 257 zcmaFFet~_0IF};_8v_G_fbY4d8x;c>C(mL`nViL_Ik|{QBF5Fg#M!{n)Wp%)$k@=( z)y%@!($UG>(8R#V(8d-sRtj$r0K96+0Vep#!z;f V#Z{uG-56*NgQu&X%Q~loCIGP^Oz{8! delta 275 zcmcb>{)l~oIF~mE8v_Hw#%phzH!21&PQJsaG&zegdvY0*skK5yZh^0_m1kaYNn&1d zs;7&s5>P}hGc(1?)Xmb>(9*)p(#6Ew(9qS)!q~#X(%j9_)Y;V7)y>>#@-Idi1*jr( zoQhU48Sp?AnSc~ceufY*1q&!Khh+(0c`pKVqMxUWV@SoVk_mxa2Mjozt%cv$r$kG> z77(&OA|7bCdR3VF5l?^hBkhKQe3hnFN7h_gc&SM5$JP>V4UreOwMA|oLs~t5o2Ir;b?4N>f&f@WMXLO zYGz?<>F8u`XkuVw=wxQ@XrQD}kz3&FYvq|&T#}fVoa*Ufs{|C$%gju%g6eg~rFZf# zM$5^one=&_oQ=#JE!>GTYaS+d6uhC~YlELe4=H}gilgZY=Gk_KI~bAPNo=xeEO#^vuYS>j{o zjt0NOuPrty_AyrMSS;Y}xbv29xn<{>;KoVrVT(&Htzh18eCpTO!Zy#t!sW5sUG43H vFaCV=|H8ZV)(VTd3LCuVJ=(d0MS|gXE%%h{S+6XB?qTqB^>bP0l+XkKMs{|| delta 361 zcmbQvv7KXrIM*}|HUC*NUInw-U$J-Lj@)LNk;x4_re$}_LHBrz{J z)zigR2`HkMnVDi`>SpO`XldbS>0)ATXy|HYVQgVxY3}A|>TGK4>SpdV`4^*%f|-+r ztCOjv5l%&`m<)KJCRu@--N6OwRlN z-zZIO!dbpUJ#suwno}7Tt(tC|q|dW>_HkYbzG4osr~{i)4sMcj=lABgr}&+t@!$j7 z;wH|NFFRkz{o%;oyn$iPi-VqFi`(kG%U8Z_Q8#4kH~PG9=G!R(BC9xlJG&|Id^x>h z+JZJ?2StxRKW~Jj?VF|g(PgFn*G+sk+Fvkv=&##Q!>+zu(`=LQ^Ynt6-q$O)GcYr( Yc`e{ozjo6@pnDlSUHx3vIVCg!0Cnhs^#A|> diff --git a/assets/img/bottom-vignette@3x.png b/assets/img/bottom-vignette@3x.png index 7fd29b7d7ea207e7dec1f9798a8c859978ca6faa..23d2c6043a9e9cb80d6114d9fafad35bac6092ae 100644 GIT binary patch delta 434 zcmX@Z`JZEgIM-ngHUGC7M;b8-=rM2wNCv5AYRsfnYpk%^(9 ztC@wdrK6L%p^1T!p_7@pqk)n_MQ(wwua#$BaYbTKiW{EW!}Cg2PfP+|_NFM09i0nmxBJzX3_DsH_Ay~%e( zfg>g2-~Z`1*R13{wXiHc`x5&p!@~<5LRZSG6~{dktz*Cb+$16SqKQoA1=F)WYx>VD zOk8}|qUi4hJ%uBJkCz)6?cj6$tyd%Uy=J|<5Z=JZ&@Qh&?bTb=vp|1yGI+ZBxvXO delta 511 zcmey*afWk(IM+iCHUC*NUInw-U$J-Lj@)LNk;x4_re$}_LHBrz{J z)zigR2`HkMnVDi`=49dOWNK+@>0)ATXy|HYVQgVxY3}A|>TGK4>SpdV`4^*%0#uP1 zPDQJj40xc5j6sSfKSKzZfCZG8!|G?e1p>uNu|nSFXf-A}(3{VCVh$u_>_c=w-UnQ1_N zLS)z*&H@c)Cws|htjqHQt~Y1a{c%|LQbbsz{MM5B6PA6P)UT%Q+9>c^bq^zBeaFGQ z_30I|0a4M@SXrJmnoU!DdU=V#-xoS9v$EB=CzYMxue#VNdM0SE#boZfBIYu_KaruW zKUCzuUFwi(G(S6iS$0vGUb=So%l{wrmV0Y0iP`W%(IMfM&X+x67lQwMR(&h6qQCUp z`HM$2Q-st1E66PrUGge+3dhYKm0^qew!WF=lkFE)9(7yu&sCLISL_WpES6vWUN7pS z&-n>o^x90W`QD0Rzwt1G%aGf~Y{M@tQQj-t{gyddvD7&_Onq?li^2aQdwV7xhM*?> V=8ZFAZU7^i!PC{xWt~$(69Cz-&kg_p diff --git a/assets/img/top-vignette.png b/assets/img/top-vignette.png index 978b0bde58e14b7a69c203d65bbc86a673539aac..6ba7130ea24f9034e0b5c2e2205c4a2e7d795b7c 100644 GIT binary patch delta 271 zcmaFLevf^EIF};_8v_G_fbY4d8x;c>C(mL`nViL_Ik|{QBF4bL!qM2k)YQ?~$i&dl z)y%@!($UG>(8R#V(8RWx&|>crNw=6l#s!yL?qA5!y}g#_gxNXXa}${bCrP}hGc(1?)Xmb>(9*)l(#6Ew(9qS)!q~#X(%j9_)Y;V7)y>>#@-Idi1*jrp zoQhU48Sp?A8GsZ`eufY*1PdrJhvoj)=r{v(VxXssV@SoVo(X|`4F(*}ugm^(d(ZSc zJFO)1%KWx(f*cG70(WgOT6INB-FI@J=GN9(7gIi7F1jWCCM{#ezJSy3r*eBZ&$j&f j*SG(Q-fdM2RtW~96pwk0rY3uVhBJ7&`njxgN@xNAR|#G; diff --git a/assets/img/top-vignette@2x.png b/assets/img/top-vignette@2x.png index 3ef500ee17bcdf78a52c1bd8037a042f7f4f7f6f..56f6f2ae446903178b74279d4ef1d8657ada3ac6 100644 GIT binary patch delta 317 zcmdnRF_&Y4I9C$~8v_GF4x8kkjfw$`lV>reOwMA|oLs~t5o2Ir;b?4NYUyZfWMXLO zYGz?<>F8u`XkuVw=wxQ@XrQD}kz3&FYvq|&T#}fVoa*Ufs{|C$%gju%g6ahtfL-t8 zUyPQMS2LM0I!%^imYn>XNr}-J$cn1Z3a!-!I;hjr#WAGf){~%Uz5@yz&AH$0Z?0Q1 zcb2CUgZ%HgoSv*v0*Okyx-W+ESS$RV_n7sC;tw6)@HKlBW+Xc@u9T1#`!h$>apCeC z#u~Hkyb7C8W+Suz?z0V&OkuY_l%_dzq*d&=JmblR$k_{?=R5qLzRE5lS%+(z={ojw rwf!7>t9FRz>aaz*MA$R+GcYr#KWJHV(AvBg=qd(JS3j3^P6C*NUInw-U$J-Lj@R9T@Sx4_re$}_LHBrz{J z)zigR2`HkMnVDkcqZW?kk~mm}*mmrBlDcjxda zjg_A{CAQs|8h^4t+~ZjA3mG5gGhb(|oEvg_Mo9hAfLTgB-##>?*!nGN*_&jlq1tn1 z=GX0s)`d33OTRjX+;%(qDX;OPMTF0kD_b8dc3vKT*O8~jNFu#Z?|E```Mmv?J5;iH yI_s>3pI34v$>ci!=Xy8w$)hJ1e@ZTAU}kW;x?S8R$?YD{$qb&ZelF{r5}E)?zkQhi diff --git a/assets/img/top-vignette@3x.png b/assets/img/top-vignette@3x.png index cc25c4751119904f01770d4c146f6536a00d2729..73b35b0f99ab8badc46dc6f1ed4a7034a38b4891 100644 GIT binary patch delta 435 zcmX@YIf-+EIM-ngHUGC7M;b8-=rM2wNCv5AYRsez-hk%^(9 ztC@wdrK6L%p^1T!p_7@pqk)n_MQ(wwua#$BaYsK8sngn#vKTj9OkcwMxLf`ToR^SNP{k?wE z-k_almzf0EZTWZC$H#f%=O-drnoncTUEC*}v*%p?|HgNU-@MKzu8{E9@~G;QgxLYP zI~R3iTkgD&WPWnmDylS@>;2QbTj^8Vm3OY`lT>J*CdbNf?@B@St~2-5?VZ*!71frV zD;2JP>3YKVXoSB{drFUB#UrJ_427>pP9^eLO;2epJ^Qutzybe7mUp^Tv_g;YB)vR7 z>lnWPTa@jWTEVKIom$>fy}_*?GUKM&Op6P>VY!uksqudH=Bf*qnih3w-R1u1@avgm z-RVNF)J O!QkoY=d#Wzp$PzdOS2FF delta 409 zcmV;K0cQS^3B(DI7YgAB1^@s64Wth?u^~_aliUF!lWGBLlXe0%2q1WEa7|4*Nt4F{ zHIw`S8j}_SA(N{DHUT-49s?PZ`vM{XL6aT>T7MjYJCXnZ0We8KK~#9!oL12i!ypJl zxBvfSvt4g?MF@z!+k*#XNeI*?B9PzH<^SN#A~GYG5uP@_zcvr@e8*I)9Quktp_UaJ zo^Y-xMSvm#Rn7cQd#`Ey9jv-t1q`{Vs49S%f?I94aG#5_px2xKqe2@xKVQPR16|p^ME^a*z-~@uW)f9zz7Lu7$ z_TP}IKQw?rz)KsZJ_W9h*|2^WHb*8lIiDZot>;}B>2mN}Qb52zMkrR>uvo!~g?)g7 zrOJ(D*ApLf|Ij^hIB-?+T{!6J?k4Xk?M@BvY;J#k3s7mXEsyU=G3|S8^l%p9+u+93 z%j%uDGz#Qy-8w_STW`JNGkr}Dm );