compensate for xcodebuild bug where 'archive' always claims to succeed

xcodebuild's archive action always claims to succeed (with exit status
of 0) even when there are failing build commands.

To compensate, we only claim xcodebuild succeeds when we see no failing
build commands from xcodebuild.

Author: fpotter

xctool/xctool-tests/ArchiveActionTests.m

@@ -42,4 +42,75 @@ - (void)testArchiveActionTriggersBuildForProjectAndScheme
   }];
 }
 
+- (void)testArchiveWithFailingCommandShouldFail
+{
+  [[FakeTaskManager sharedManager] runBlockWithFakeTasks:^{
+    [[FakeTaskManager sharedManager] addLaunchHandlerBlocks:@[
+     // Make sure -showBuildSettings returns some data
+     [LaunchHandlers handlerForShowBuildSettingsWithProject:TEST_DATA @"TestProject-App-OSX/TestProject-App-OSX.xcodeproj"
+                                                     scheme:@"TestProject-App-OSX"
+                                               settingsPath:TEST_DATA @"TestProject-App-OSX-showBuildSettings.txt"],
+     [[^(FakeTask *task){
+      if ([[task launchPath] hasSuffix:@"xcodebuild"] &&
+          [[task arguments] containsObject:@"archive"])
+      {
+        [task pretendTaskReturnsStandardOutput:
+         [NSString stringWithContentsOfFile:TEST_DATA @"xcodebuild-archive-bad.txt"
+                                   encoding:NSUTF8StringEncoding
+                                      error:nil]];
+        // Even when archive fails, 'xcodebuild' returns zero.
+        [task pretendExitStatusOf:0];
+      }
+    } copy] autorelease],
+     ]];
+
+    XCTool *tool = [[[XCTool alloc] init] autorelease];
+
+    tool.arguments = @[@"-project", TEST_DATA @"TestProject-App-OSX/TestProject-App-OSX.xcodeproj",
+                       @"-scheme", @"TestProject-App-OSX",
+                       @"archive",
+                       ];
+
+    NSDictionary *output = [TestUtil runWithFakeStreams:tool];
+
+    assertThatInt([tool exitStatus], equalToInt(1));
+    assertThat(output[@"stdout"], containsString(@"** ARCHIVE FAILED **"));
+  }];
+}
+
+- (void)testArchiveWithAllPassingCommandsShouldSucceed
+{
+  [[FakeTaskManager sharedManager] runBlockWithFakeTasks:^{
+    [[FakeTaskManager sharedManager] addLaunchHandlerBlocks:@[
+     // Make sure -showBuildSettings returns some data
+     [LaunchHandlers handlerForShowBuildSettingsWithProject:TEST_DATA @"TestProject-App-OSX/TestProject-App-OSX.xcodeproj"
+                                                     scheme:@"TestProject-App-OSX"
+                                               settingsPath:TEST_DATA @"TestProject-App-OSX-showBuildSettings.txt"],
+     [[^(FakeTask *task){
+      if ([[task launchPath] hasSuffix:@"xcodebuild"] &&
+          [[task arguments] containsObject:@"archive"])
+      {
+        [task pretendTaskReturnsStandardOutput:
+         [NSString stringWithContentsOfFile:TEST_DATA @"xcodebuild-archive-good.txt"
+                                   encoding:NSUTF8StringEncoding
+                                      error:nil]];
+        [task pretendExitStatusOf:0];
+      }
+    } copy] autorelease],
+     ]];
+
+    XCTool *tool = [[[XCTool alloc] init] autorelease];
+
+    tool.arguments = @[@"-project", TEST_DATA @"TestProject-App-OSX/TestProject-App-OSX.xcodeproj",
+                       @"-scheme", @"TestProject-App-OSX",
+                       @"archive",
+                       ];
+
+    NSDictionary *output = [TestUtil runWithFakeStreams:tool];
+
+    assertThatInt([tool exitStatus], equalToInt(0));
+    assertThat(output[@"stdout"], containsString(@"** ARCHIVE SUCCEEDED **"));
+  }];
+}
+
 @end