Start video if clicking timestamp in description

[Perflyst]

If clicking a timestamp in description the video does not start and I thought something is broken. I had to click the timestamp in description and than the play button.

I think it makes sense that the video starts automatically after clicking the timestamp.

Example: https://invidio.us/watch?v=tBiPumGnVT4

[leonklingele]

What about the following patch?

diff --git a/src/invidious/comments.cr b/src/invidious/comments.cr
index e060fe4..217963f 100644
--- a/src/invidious/comments.cr
+++ b/src/invidious/comments.cr
@@ -482,7 +482,7 @@ def replace_links(html)
       end

       anchor["href"] = "javascript:void(0)"
-      anchor["onclick"] = "player.currentTime(#{length_seconds})"
+      anchor["onclick"] = "player.currentTime(#{length_seconds}); player.play();"
     end
   end

[omarroth]

LGTM, mind opening a PR?

[github-actions]

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

[Mennaruuk]

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

Stale yourself, bot! This is a good suggestion. As far as I can see, on my iPhone X, the video plays after every time stamp I click in the description box. Should this issue be closed?

[Mennaruuk]

I'm not sure what OP means.

1. Do they want the video to play whenever they click any of the timestamps in the description box, regardless of whether the video was already playing or paused? In that case, this behavior isn't currently implemented as far as I can see.

2. Do they want the video to play whenever they click any of the timestamps in the description box, but so long as the video is already playing and isn't paused? In that case, yes, that's what's going on right now.

[github-actions]

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

[Mennaruuk]

Stale yourself again, bot!