Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] No timestamp when hovering the progress bar #2941

Closed
hl2guide opened this issue Feb 26, 2022 · 5 comments · Fixed by #3011
Closed

[Bug] No timestamp when hovering the progress bar #2941

hl2guide opened this issue Feb 26, 2022 · 5 comments · Fixed by #3011
Labels
bounty bounty:10$ bug Something isn't working module:player Impacts the video player of Invidious

Comments

@hl2guide
Copy link

Is your enhancement request related to a problem? Please describe.
The video player does not show the timestamp for the point on the trackbar (when am I jumping to?)

Describe the solution you'd like
Please add a timestamp to the trackbar hover thumbnail in the video player.
@hl2guide hl2guide added the enhancement Improvement of an existing feature label Feb 26, 2022
@unixfox
Copy link
Member

unixfox commented Feb 26, 2022

Can you give a better example of what you are talking about?

@SamantazFox
Copy link
Member

I think that they're talking about that. This was probably broken when we updated VideoJS.

image

@SamantazFox SamantazFox added the module:player Impacts the video player of Invidious label Feb 26, 2022
@SamantazFox SamantazFox changed the title [Enhancement] Video Player Trackbar Thumbnail Image Improvement [Bug] No timestamp when hovering the progress bar Feb 26, 2022
@SamantazFox SamantazFox added bug Something isn't working and removed enhancement Improvement of an existing feature labels Feb 26, 2022
@hl2guide
Copy link
Author

@SamantazFox yep that's it.

@TheFrenchGhosty
Copy link
Member

A 10$ bounty has been added to this issue.

Anyone opening a PR fixing this issue, will receive 10$ (in BTC) from the Invidious project.

More details: #1898

@unixfox
Copy link
Member

unixfox commented Apr 17, 2022

Fixed in #3011

Not intentional, I just happened to see that it got fixed in a newer videojs version.
image

@unixfox unixfox mentioned this issue Apr 17, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty bounty:10$ bug Something isn't working module:player Impacts the video player of Invidious
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump videojs to 7.12.1 iv-org/invidious
4 participants
@unixfox @hl2guide @TheFrenchGhosty @SamantazFox