ConversionFailedException: When accessing v3/api-docs. Fixes springdoc#1097

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/ParameterInfo.java

@@ -24,6 +24,8 @@
 
 import io.swagger.v3.oas.annotations.enums.ParameterIn;
 import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import org.springframework.core.MethodParameter;
 import org.springframework.core.convert.TypeDescriptor;
@@ -69,6 +71,8 @@ public class ParameterInfo {
 	 */
 	private String paramType;
 
+	private static final Logger LOGGER = LoggerFactory.getLogger(ParameterInfo.class);
+
 
 	/**
 	 * Instantiates a new Parameter info.
@@ -99,10 +103,18 @@ else if (cookieValue != null)
 
 		if (StringUtils.isNotBlank(this.pName))
 			this.pName = propertyResolverUtils.resolve(this.pName);
-		if (this.defaultValue !=null && !ValueConstants.DEFAULT_NONE.equals(this.defaultValue.toString())){
+		if (this.defaultValue != null && !ValueConstants.DEFAULT_NONE.equals(this.defaultValue.toString())) {
 			this.defaultValue = propertyResolverUtils.resolve(this.defaultValue.toString());
 			parameterBuilder.getOptionalWebConversionServiceProvider()
-					.ifPresent(conversionService ->this.defaultValue= conversionService.convert(this.defaultValue, new TypeDescriptor(methodParameter)));
+					.ifPresent(conversionService -> {
+								try {
+									this.defaultValue = conversionService.convert(this.defaultValue, new TypeDescriptor(methodParameter));
+								}
+								catch (Exception e) {
+									LOGGER.warn("Using the following default value : {}, without spring conversionService", this.defaultValue);
+								}
+							}
+					);
 		}
 
 		this.required = this.required && !methodParameter.isOptional();

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app153/OrderState.java

@@ -0,0 +1,20 @@
+package test.org.springdoc.api.app153;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+
+
+@Schema(type="string", allowableValues={"finished", "new"})
+public enum OrderState {
+	FINISHED("finished"),
+	NEW("new");
+
+	OrderState(String value) {
+		this.value = value;
+	}
+
+	public String getValue() {
+		return value;
+	}
+
+	private final String value;
+}

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app153/OrderStateMapper.java

@@ -0,0 +1,19 @@
+package test.org.springdoc.api.app153;
+
+import java.beans.PropertyEditorSupport;
+import java.util.Arrays;
+
+import org.springframework.web.method.annotation.MethodArgumentTypeMismatchException;
+
+public class OrderStateMapper extends PropertyEditorSupport {
+
+	@Override
+	public void setAsText(String text) {
+		setValue(
+				Arrays.stream(OrderState.class.getEnumConstants())
+						.filter(e -> e.getValue().equals(text))
+						.findFirst()
+						.orElseThrow(() -> new MethodArgumentTypeMismatchException(
+								text, OrderState.class, "orderState", null, null)));
+	}
+}

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app153/SpringDocApp153Test.java

@@ -0,0 +1,34 @@
+/*
+ *
+ *  * Copyright 2019-2020 the original author or authors.
+ *  *
+ *  * Licensed under the Apache License, Version 2.0 (the "License");
+ *  * you may not use this file except in compliance with the License.
+ *  * You may obtain a copy of the License at
+ *  *
+ *  *      https://www.apache.org/licenses/LICENSE-2.0
+ *  *
+ *  * Unless required by applicable law or agreed to in writing, software
+ *  * distributed under the License is distributed on an "AS IS" BASIS,
+ *  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  * See the License for the specific language governing permissions and
+ *  * limitations under the License.
+ *
+ */
+
+package test.org.springdoc.api.app153;
+
+
+import test.org.springdoc.api.AbstractSpringDocTest;
+
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
+/**
+ * Tests Spring meta-annotations as method parameters
+ */
+public class SpringDocApp153Test extends AbstractSpringDocTest {
+
+	@SpringBootApplication
+	static class SpringDocTestApp {}
+
+}

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app153/TestController.java

@@ -0,0 +1,22 @@
+package test.org.springdoc.api.app153;
+
+import org.springframework.web.bind.WebDataBinder;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.InitBinder;
+import org.springframework.web.bind.annotation.RequestParam;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+class TestController {
+
+	@InitBinder
+	public void initBinder(WebDataBinder dataBinder) {
+		dataBinder.registerCustomEditor(OrderState.class, new OrderStateMapper());
+	}
+
+	@GetMapping(value = {"/orders"})
+	public Object method(
+			@RequestParam(value = "state", defaultValue = "finished") OrderState orderState) {
+		return null;
+	}
+}

springdoc-openapi-webmvc-core/src/test/resources/results/app153.json

@@ -0,0 +1,51 @@
+{
+  "openapi": "3.0.1",
+  "info": {
+    "title": "OpenAPI definition",
+    "version": "v0"
+  },
+  "servers": [
+    {
+      "url": "http://localhost",
+      "description": "Generated server url"
+    }
+  ],
+  "paths": {
+    "/orders": {
+      "get": {
+        "tags": [
+          "test-controller"
+        ],
+        "operationId": "method",
+        "parameters": [
+          {
+            "name": "state",
+            "in": "query",
+            "required": false,
+            "schema": {
+              "type": "string",
+              "enum": [
+                "finished",
+                "new"
+              ],
+              "default": "finished"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "OK",
+            "content": {
+              "*/*": {
+                "schema": {
+                  "type": "object"
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  },
+  "components": {}
+}