Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top controls don't work on iPhoneX in portrait mode #118

Closed
akandaurov opened this issue Oct 19, 2018 · 4 comments
Closed

Top controls don't work on iPhoneX in portrait mode #118

akandaurov opened this issue Oct 19, 2018 · 4 comments

Comments

@akandaurov
Copy link

akandaurov commented Oct 19, 2018

Top controls: back, volume, zoom don't work on iPhoneX in portrait mode
Control styles are hardcoded and can't be customized, e.g.
styles.controls.topControlGroup: {
...
margin: 12
marginBottom: 18
}

@fendorio
Copy link
Contributor

fendorio commented Nov 5, 2018

Could you wrap your video in React Native's SafeAreaView?

@akandaurov
Copy link
Author

I'll try, but the video won't take full screen in this case which may not look good

@akandaurov
Copy link
Author

SafeAreaView does additional padding in the bottom and does paddings in landscape orientation as well which I don't need at all. Also padding solution is not good. I did a fork with customizable top and bottom control group styles and then adjusted top margin for top group controls in my code when run on iPhoneX and in portrait orientation.

@kylemilloy
Copy link
Contributor

This is fixed in way back in 2.3 as part of a fix to resolve #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants