Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve floating button code for better readability and maintainability #51

Merged
merged 6 commits into from
Sep 15, 2024

Conversation

itsmartashub
Copy link
Owner

Close #49

- Initiate code improvements for the floating button to enhance performance and readability

Changes summary:
- Started the process of improving the floating button code, aiming to enhance its performance, readability, and overall quality.
- Split accent color logic and theme management logic from the floating button file into a separate file for improved readability and maintainability

Changes summary:
- Extracted accent color and theme management logic from the floating button file:
  - Improved code organization and readability by separating concerns into distinct files.
  - Enhanced maintainability by making it easier to update and modify accent color and theme management logic independently.
…oating code

- Split themeManager and settingsManager into separate files for better organization
- Improve code for enhanced performance and maintainability

Changes summary:
- Refactored the floating code by splitting themeManager and settingsManager into separate files, improving organization and maintainability.
- Optimized the code for better performance, making it more efficient and easier to maintain.
…anager`

- Address and resolve errors introduced by splitting `settingsManager`
- Ensure settings functionality is restored and working correctly

Changes summary:
- Fixed the errors and issues that arose from splitting the `settingsManager`, restoring the settings functionality to its previous working state.
…pth-settings`

- Improve the floating button code for better performance and readability
- Increase the gpth-settings to avoid breaking on huge scrollbars
- Rename assets to widths for clarity and consistency

Changes summary:
- Enhanced the floating button code:
  - Improved performance and readability by refactoring the code.
  - Increased the gpth-settings to ensure the floating button remains functional even on huge scrollbars.
  - Renamed assets to widths for better clarity and consistency in the codebase.
@itsmartashub itsmartashub self-assigned this Sep 15, 2024
@itsmartashub itsmartashub merged commit 0ec5fd7 into main Sep 15, 2024
2 checks passed
@itsmartashub itsmartashub deleted the refactor/floating-btn branch September 15, 2024 19:42
@itsmartashub itsmartashub restored the refactor/floating-btn branch September 15, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve floating button code for better readability and maintainability
1 participant