From 535c6a8176065ef56036463b83a5f0d2b3e89ac3 Mon Sep 17 00:00:00 2001 From: LangChain4j Date: Mon, 18 Nov 2024 17:00:05 +0100 Subject: [PATCH] Update CONTRIBUTING.md Retrofit -> Java 11 HTTP Client --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b4e6467d1cc..ea29e3b37f2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,7 +46,7 @@ Please note that we do not have the capacity to review PRs immediately. We ask f - [Integration with Anthropic](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-anthropic) is a good example. - Use the official SDK if available. -- If the official SDK is not available, use Retrofit and Jackson to implement the client. +- If the official SDK is not available, use Java 11 HTTP Client and Jackson to implement the client. - Document the new integration [here](https://github.com/langchain4j/langchain4j/blob/main/README.md), [here](https://github.com/langchain4j/langchain4j/tree/main/docs/docs/integrations/language-models) and [here](https://github.com/langchain4j/langchain4j/blob/main/docs/docs/integrations/language-models/index.md). - Add an example to the [examples repository](https://github.com/langchain4j/langchain4j-examples), similar to [this](https://github.com/langchain4j/langchain4j-examples/tree/main/anthropic-examples). - Add a new module to the appropriate section of the [BOM](https://github.com/langchain4j/langchain4j/blob/main/langchain4j-bom/pom.xml). @@ -56,7 +56,7 @@ Please note that we do not have the capacity to review PRs immediately. We ask f - [Integration with Chroma](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-chroma) is a good example. - Use the official SDK if available. -- If the official SDK is not available, use Retrofit and Jackson to implement the client. +- If the official SDK is not available, use Java 11 HTTP Client and Jackson to implement the client. - Add a `{IntegrationName}EmbeddingStoreIT`. It should extend from `EmbeddingStoreWithFilteringIT` (when store supports metadata filtering) or `EmbeddingStoreIT` and pass all tests. - Add a `{IntegrationName}EmbeddingStoreRemovalIT`. It should extend from `EmbeddingStoreWithRemovalIT` and pass all tests. - Document the new integration [here](https://github.com/langchain4j/langchain4j/blob/main/README.md), [here](https://github.com/langchain4j/langchain4j/tree/main/docs/docs/integrations/embedding-stores) and [here](https://github.com/langchain4j/langchain4j/blob/main/docs/docs/integrations/embedding-stores/index.md).