Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

Commit 6af60ff

Browse files
committed
chore(webpack): moves all depdencies into vendor bundle
1 parent b2d0a48 commit 6af60ff

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
66
and this project adheres to [Semantic Versioning](http://semver.org/).
77

88
## [Unreleased][]
9+
### Changed
10+
- Move all dependencies into vendor bundle
911

1012
## [4.43.4][] - 2017-10-09
1113
### Changed

config/webpack.config.app.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
const createConfig = require('./webpackConfigFactory');
22
const paths = require('./paths');
3+
const dependencies = require('../package.json').dependencies;
4+
5+
const ignoreDependencies = [
6+
'normalize.css',
7+
'babel-polyfill',
8+
];
39

410
const common = {
511
name: 'app',
@@ -11,12 +17,7 @@ const common = {
1117
inject: true,
1218
},
1319
entry: {
14-
vendor: [
15-
'react',
16-
'react-dom',
17-
'redux',
18-
'react-router-dom',
19-
],
20+
vendor: Object.keys(dependencies).filter((dep) => !ignoreDependencies.includes(dep)),
2021
},
2122
};
2223

package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"fastclick": "^1.0.6",
3535
"function-batch": "^1.1.2",
3636
"gw2e-item-attributes": "^1.2.0",
37-
"gw2itemstats": "^0.0.2",
3837
"i18n-react": "^0.3.0-ts1",
3938
"lodash": "^4.14.1",
4039
"lz-string": "^1.4.4",
@@ -52,8 +51,7 @@
5251
"recompose": "^0.25.0",
5352
"redux": "^3.7.2",
5453
"redux-thunk": "^2.1.0",
55-
"reselect": "^3.0.1",
56-
"zip-folder": "^1.0.0"
54+
"reselect": "^3.0.1"
5755
},
5856
"devDependencies": {
5957
"app-module-path": "^2.2.0",
@@ -138,6 +136,7 @@
138136
"webpack-dev-server": "^2.7.1",
139137
"webpack-manifest-plugin": "^1.3.1",
140138
"webpack-md5-hash": "^0.0.5",
141-
"yargs": "^8.0.2"
139+
"yargs": "^8.0.2",
140+
"zip-folder": "^1.0.0"
142141
}
143142
}

yarn.lock

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3332,10 +3332,6 @@ gw2e-item-attributes@^1.2.0:
33323332
version "1.2.3"
33333333
resolved "https://registry.yarnpkg.com/gw2e-item-attributes/-/gw2e-item-attributes-1.2.3.tgz#5631edf4ec13f368b90d8a4d88c38982c76a2157"
33343334

3335-
gw2itemstats@^0.0.2:
3336-
version "0.0.2"
3337-
resolved "https://registry.yarnpkg.com/gw2itemstats/-/gw2itemstats-0.0.2.tgz#899f5e180653fda51cbd44dcbe4a90cad41b007c"
3338-
33393335
gzip-size@^3.0.0:
33403336
version "3.0.0"
33413337
resolved "https://registry.yarnpkg.com/gzip-size/-/gzip-size-3.0.0.tgz#546188e9bdc337f673772f81660464b389dce520"

0 commit comments

Comments
 (0)