Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): prevent memory leaks from retained jobs #502

Merged
merged 1 commit into from
Jun 9, 2018

Conversation

Ignigena
Copy link
Contributor

@Ignigena Ignigena commented Jun 8, 2018

Ran into the same issue as #499 particularly since our application uploads a number of files and is rarely re-launched. This PR simply removes the job from the NSMutableDictionary as soon as it either succeeds or fails.

@itinance itinance merged commit 8468d43 into itinance:master Jun 9, 2018
@itinance
Copy link
Owner

itinance commented Jun 9, 2018

Good catch, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants