Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add jobId condition inside upload event #1226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olehkykush
Copy link

Hi, many thanks for this project!

Problem that I encountered:
When I called multiple RNFS.uploadFiles progress callbacks fire events for every upload started, not only event that related to that upload only.

If two uploads were started with jobId 1 and 2 - In progress callback I'll receive responses of jobId 1 and 2.

This patch is based on existing solution with RNFS.downloadFile progress callbacks and it helped me with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant